fix(TextArea): Spread rest props to the native textarea tag #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziperfal
changed the title
YossiSaadi
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Thanks for the contribution @ziperfal!
Please take a look at some of the concerns and suggestions I raised here 🙏🏼
YossiSaadi
changed the title
YossiSaadi
approved these changes
Sep 25, 2024
|
@ziperfal please run prettier on the types file, it fails the lint 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes:
restprops object to the nativetextareatag in order to support native HTML API.Impact:
Related:
https://monday.monday.com/boards/5896576795/pulses/7480825140
https://monday.slack.com/archives/C02S6F817JQ/p1726471392017299
ask-vibe ticket: https://monday.monday.com/boards/6965884836/pulses/7499773996
I have read the Contribution Guide for this project.