-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(docs): convert VirtualizedGrid stories FILES to TS #2530
Conversation
Converted stories and stories.helpers from JS to TSX, and add ItempType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vladboisa!
Please use existing type VirtualizedListItem
instead of creating a new type
Yep, did it. Thank you for a hint;) |
Great! there is a conflict from master can you please pull master and solve the conflict? |
@rivka-ungar Now, i think everything is great!) |
Hi @vladboisa! Thank you so much for your effort on this PR — we really appreciate the time and thought you put into it. However, with recent updates to the codebase, this change has become outdated and would be difficult to merge due to conflicts. We’ll go ahead and close this PR, but we truly value your contributions and hope to see more from you in the future. Thanks again for your understanding! 🚀 |
Resolves #2523 and #2516