Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs): convert VirtualizedGrid stories FILES to TS #2530

Closed
wants to merge 5 commits into from

Conversation

vladboisa
Copy link

@vladboisa vladboisa commented Oct 13, 2024

Resolves #2523 and #2516

Converted stories and stories.helpers from JS to TSX, and add ItempType
@vladboisa vladboisa requested a review from a team as a code owner October 13, 2024 18:39
Copy link
Contributor

@rivka-ungar rivka-ungar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vladboisa!
Please use existing type VirtualizedListItem instead of creating a new type

@vladboisa vladboisa requested a review from rivka-ungar October 15, 2024 11:08
@vladboisa
Copy link
Author

Thanks @vladboisa!
Please use existing type VirtualizedListItem instead of creating a new type

Yep, did it. Thank you for a hint;)
Thank your for opportunity and helping to Open-Source community!

@rivka-ungar
Copy link
Contributor

Thanks @vladboisa!
Please use existing type VirtualizedListItem instead of creating a new type

Yep, did it. Thank you for a hint;) Thank your for opportunity and helping to Open-Source community!

Great! there is a conflict from master can you please pull master and solve the conflict?

@talkor talkor self-assigned this Oct 20, 2024
@vladboisa
Copy link
Author

@rivka-ungar Now, i think everything is great!)

@talkor talkor assigned rivka-ungar and unassigned talkor Oct 27, 2024
@rivka-ungar
Copy link
Contributor

Hi @vladboisa! Thank you so much for your effort on this PR — we really appreciate the time and thought you put into it. However, with recent updates to the codebase, this change has become outdated and would be difficult to merge due to conflicts.

We’ll go ahead and close this PR, but we truly value your contributions and hope to see more from you in the future. Thanks again for your understanding! 🚀

@rivka-ungar rivka-ungar closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: convert VirtualizedGrid stories file to TS
3 participants