🧹 Remove adapter over msgraph-sdk-go, bump msgraph-sdk-go #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preslavgerchev
force-pushed
the
preslav/cleanup-msgraph-sdk
branch
from
e316125 to
9cdc30c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a layer over the msgraph-sdk-go, which used some code that was copied directly from the library itself.
As per microsoftgraph/msgraph-sdk-go#129 (comment), it seems that this library is now improved enough that it doesn't bloat up our binary size and builds fast
This PR removes all the adapter code and bumps the msgraph-sdk to the latest production (0.56) version
The rest is mostly changing struct names where needed