Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix dict translation for cloudrun service traffic #5101

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

vjeffrey
Copy link
Contributor

before

    traffic: failed to convert dict to primitive, unsupported child type: int32

after

    traffic: [
      0: {
        percent: "100"
        revision: ""
        tag: ""
        type: "TRAFFIC_TARGET_ALLOCATION_TYPE_LATEST"
      }
    ]

Copy link
Contributor

Test Results

3 208 tests  ±0   3 204 ✅ ±0   1m 51s ⏱️ -6s
  379 suites ±0       4 💤 ±0 
   29 files   ±0       0 ❌ ±0 

Results for commit d300a18. ± Comparison against base commit 41b6963.

@vjeffrey vjeffrey merged commit fb797bc into main Jan 17, 2025
17 checks passed
@vjeffrey vjeffrey deleted the vj/fixcloudrundict branch January 17, 2025 20:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants