-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guix: bump time-machine to 9d09b0cf841fb657a1aec12e9bab68e00c2b493c #9467
base: master
Are you sure you want to change the base?
Conversation
134be74
to
a0d4a6d
Compare
a0d4a6d
to
47a42c1
Compare
47a42c1
to
5cb0b26
Compare
|
|
|
Resolves a build failure with glibc 2.27 + binutils >=2.40. | ||
Patch can be removed if we update glibc to >= 2.35. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The post notes glibc 2.39, is this patch still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We build a custom cross-compilation toolchain that uses glibc 2.27 instead of 2.39. This patch fixes that build.
We use a lower version of glibc to build Monero than what other Guix packages are linked against. This is because the glibc version we link against determines the minimum glibc version that must be available at runtime. A binary linked against glibc 2.39 will run on Ubuntu 24.04 (glibc 2.39), but isn't guaranteed to run on Ubuntu 22.04 (glibc 2.35). Ubuntu 18.04 is the lowest version we can support by using glibc 2.27.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working on this.
Changes to the build environment
Includes packages that are available in the guix container that we use to build Monero.
(949ee85019b242d29a1065cde27c491af57b657b)
(f9e761bf138f8d8d80084149b0c3a4388e6af70c)
Link
(da26b34b0f3cf2883a4cb01e11971aad84f2ef6a).
Link
(e7fdcffc73690c675477a3e48ecdb16f8fb5dd01)
(239868c8e9b57ac92efd82558cef7ef04ad6a612)
(968c6da422997d795c8601cbbd89b3b308553e8c)
* this does not affect run-time requirements of release binaries.
Changes to transitive build dependencies
Includes (transitive) build dependencies that are not included in the build environment.
(968c6da422997d795c8601cbbd89b3b308553e8c)
Changes to commencement
Only includes changes to bootstrap packages.
(129b07dbf34e2c17ba07d8048af88e8f100ef89c)
Stats
This bump spans a Guix
core-updates
merge, which results in a larger number of updated packages than is typical.