p2p: allow comments in banlist files #9558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+2
to
+12
| 255.255.255.0 # Saruman the White | ||
| 128.128.128.0 # Gandalf the Gray | ||
| 150.75.0.0 # Radagast the Brown | ||
| 99.98.0.0/16 # All of Misty Mountain | ||
|
|
||
| # personal enemies | ||
| 1.2.3.4 # this woman used to give me swirlies | ||
| 6.7.8.9 # I just don't like the cut of his jib | ||
| 1.0.0.7#Literally James Bond, he wrecked my aston martin | ||
| 100.98.1.13 # Earl from HOA | ||
| 100.98.1.0/24 #The rest of the HOA for good measure |
SyntheticBird45
approved these changes
Nov 7, 2024
selsta
approved these changes
Nov 7, 2024
hinto-janai
approved these changes
Nov 24, 2024
In-line comments explicitly explaining banned hosts/subnets might help assuage fears of some good banlists' arbitaryiness.
jeffro256
force-pushed
the
banlist_comments
branch
from
851d35e to
b5f29ee
Compare
|
Rebased to apply this logic to the daemon command parser executor codepath as well. |
|
@jeffro256 release? |
selsta
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-line comments explicitly explaining banned hosts/subnets might help assuage fears of some good banlists' arbitaryiness.
@Boog900 @SyntheticBird45 @Rucknium