Replace keccak-hash with tiny-keccak #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency footprint of tiny-keccak is smaller and it also has a more versatile API that allows streaming bytes into the hash engine. Before: ❯ cargo tree | wc -l 56 After: ❯ cargo tree | wc -l 48
thomaseizinger
force-pushed
the
replace-keccak-hash
branch
from
4e0268f to
3e69723
Compare
4 tasks
|
LGTM It seems that the guy behind the library is not really active anymore, I don't think it's a problem tho. |
Keccak-hash uses tiny-keccak internally so that doesn't change actually :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency footprint of tiny-keccak is smaller and it also has
a more versatile API that allows streaming bytes into the hash
engine.
Before:
❯ cargo tree | wc -l
56
After:
❯ cargo tree | wc -l
48