rename bip32 to HDWallet and bip39 to Mnemonic #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhell1
force-pushed
the
fix-bips-naming
branch
4 times, most recently
from
7da2ff2 to
20f8c77
Compare
functions should be easy to understand and access from their name, which is more important than arbitrary naming schemes
Zhell1
changed the title
|
This makes so much sense. Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #253
functions should be easy to understand and access from their functional name, which is more important than arbitrary naming schemes
using
bipsas the naming scheme is confusing to newcomers (see related issue) and fails at the target purpose of:It should not be necessary to read the source code of a class or function to know how to use it / so that other developers find the code easy to understand.developers, especially newcomers, should not have to learn by heart which BIP number corresponds to a well-known feature of any bitcoin library, the feature should be described by its name for clarity and ease of use
before:
after: