Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ci config #6

Merged
merged 2 commits into from
Oct 27, 2022
Merged

fix ci config #6

merged 2 commits into from
Oct 27, 2022

Conversation

sho0126hiro
Copy link
Member

fix ci config so passing ci of this issue.

@sho0126hiro sho0126hiro self-assigned this Oct 27, 2022
@sho0126hiro
Copy link
Member Author

golintは通らなくなっているので無視してほしい @ichiki-mfw @hotakahattori

@hotakahattori
Copy link
Contributor

@sho0126hiro

Makefile 直せば ci 動くと思う

install-tools:
	mkdir -p bin; \
	go install golang.org/x/tools/cmd/goimports@$(GO_TOOLS_VERSION);
	go install github.com/golangci/golangci-lint/cmd/[email protected];
	go install github.com/golang/mock/[email protected];

[email protected] -> [email protected]

@v1.48.0 は go 1.19 じゃないと動かないらしい

ichiki-mfw
ichiki-mfw previously approved these changes Oct 27, 2022
View reviewed changes
@ichiki-mfw ichiki-mfw dismissed their stale review October 27, 2022 04:23

脳死approveしてしまった

hotakahattori
hotakahattori approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@hotakahattori hotakahattori left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自分は OK です

@sho0126hiro
Copy link
Member Author

@hotakahattori @ichiki-mfw レビューありがとう！
makefile修正 & ci config修正して問題なさそうなのでマージします
（go 1.19 へのbump up はまた別PRで対応予定）

@sho0126hiro sho0126hiro merged commit cb86423 into develop Oct 27, 2022
@sho0126hiro sho0126hiro deleted the fix_ci branch October 27, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotakahattori hotakahattori hotakahattori approved these changes

@ichiki-mfw ichiki-mfw ichiki-mfw left review comments

Assignees

@sho0126hiro sho0126hiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sho0126hiro @hotakahattori @ichiki-mfw