feat!: Update eslint-plugin-promise version (#345)

* feat!: Update eslint-plugin-promise version * update snapshot
moneyforward · Dec 7, 2024 · e7abb32 · e7abb32
1 parent 37927c4
commit e7abb32
Show file tree

Hide file tree

Showing 10 changed files with 95 additions and 560 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -50,7 +50,7 @@
     "eslint-plugin-jsdoc": "^48.2.1",
     "eslint-plugin-jsx-a11y": "^6.8.0",
     "eslint-plugin-n": "^17.7.0",
-    "eslint-plugin-promise": "^6.1.1",
+    "eslint-plugin-promise": "^7.2.1",
     "eslint-plugin-react": "^7.34.0",
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-storybook": "^0.8.0",

diff --git a/tests/snapshot-test/eslintrc/next/__snapshots__/snapshot.test.js.snap b/tests/snapshot-test/eslintrc/next/__snapshots__/snapshot.test.js.snap
@@ -290,6 +290,7 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
         "allowShortCircuit": true,
         "allowTaggedTemplates": true,
         "allowTernary": true,
+        "enforceForJSX": false,
       },
     ],
     "@typescript-eslint/no-unused-vars": [
@@ -405,6 +406,8 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
       2,
       {
         "allowImplicit": true,
+        "allowVoid": false,
+        "checkForEach": false,
       },
     ],
     "arrow-body-style": [
@@ -425,6 +428,8 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
       0,
       {
         "ignoreDestructuring": false,
+        "ignoreGlobals": false,
+        "ignoreImports": false,
         "properties": "never",
       },
     ],
@@ -447,6 +452,7 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
     "class-methods-use-this": [
       2,
       {
+        "enforceForClassFields": true,
         "exceptMethods": [],
       },
     ],
@@ -601,6 +607,7 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
       2,
       {
         "allowUnsafeDynamicCyclicDependency": false,
+        "disableScc": false,
         "ignoreExternal": false,
         "maxDepth": "∞",
       },
@@ -734,6 +741,7 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
             "internal",
           ],
         ],
+        "named": false,
         "warnOnUnassignedImports": false,
       },
     ],
@@ -1303,6 +1311,7 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
         ],
         "newIsCap": true,
         "newIsCapExceptions": [],
+        "properties": true,
       },
     ],
     "no-alert": [
@@ -1457,6 +1466,7 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
       {
         "allow": [],
         "boolean": false,
+        "disallowTemplateShorthand": false,
         "number": true,
         "string": true,
       },
@@ -1986,6 +1996,11 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
         "allow": [],
         "allowAfterSuper": false,
         "allowAfterThis": false,
+        "allowAfterThisConstructor": false,
+        "allowFunctionParams": true,
+        "allowInArrayDestructuring": true,
+        "allowInObjectDestructuring": true,
+        "enforceInClassFields": false,
         "enforceInMethodNames": true,
       },
     ],
@@ -2028,6 +2043,7 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
         "allowShortCircuit": true,
         "allowTaggedTemplates": true,
         "allowTernary": true,
+        "enforceForJSX": false,
       },
     ],
     "no-unused-labels": [

diff --git a/tests/snapshot-test/eslintrc/node/__snapshots__/snapshot.test.js.snap b/tests/snapshot-test/eslintrc/node/__snapshots__/snapshot.test.js.snap
@@ -14,6 +14,8 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
       2,
       {
         "allowImplicit": true,
+        "allowVoid": false,
+        "checkForEach": false,
       },
     ],
     "arrow-body-style": [
@@ -34,6 +36,8 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
       2,
       {
         "ignoreDestructuring": false,
+        "ignoreGlobals": false,
+        "ignoreImports": false,
         "properties": "never",
       },
     ],
@@ -56,6 +60,7 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
     "class-methods-use-this": [
       2,
       {
+        "enforceForClassFields": true,
         "exceptMethods": [],
       },
     ],
@@ -89,6 +94,7 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
       2,
       {
         "allowKeywords": true,
+        "allowPattern": "",
       },
     ],
     "eqeqeq": [
@@ -206,6 +212,7 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
       2,
       {
         "allowUnsafeDynamicCyclicDependency": false,
+        "disableScc": false,
         "ignoreExternal": false,
         "maxDepth": "∞",
       },
@@ -339,6 +346,7 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
             "internal",
           ],
         ],
+        "named": false,
         "warnOnUnassignedImports": false,
       },
     ],
@@ -468,6 +476,7 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
         ],
         "newIsCap": true,
         "newIsCapExceptions": [],
+        "properties": true,
       },
     ],
     "no-alert": [
@@ -622,6 +631,7 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
       {
         "allow": [],
         "boolean": false,
+        "disallowTemplateShorthand": false,
         "number": true,
         "string": true,
       },
@@ -1145,6 +1155,11 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
         "allow": [],
         "allowAfterSuper": false,
         "allowAfterThis": false,
+        "allowAfterThisConstructor": false,
+        "allowFunctionParams": true,
+        "allowInArrayDestructuring": true,
+        "allowInObjectDestructuring": true,
+        "enforceInClassFields": false,
         "enforceInMethodNames": true,
       },
     ],
@@ -1187,6 +1202,7 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
         "allowShortCircuit": true,
         "allowTaggedTemplates": true,
         "allowTernary": true,
+        "enforceForJSX": false,
       },
     ],
     "no-unused-labels": [

diff --git a/tests/snapshot-test/eslintrc/react/__snapshots__/snapshot.test.js.snap b/tests/snapshot-test/eslintrc/react/__snapshots__/snapshot.test.js.snap
@@ -227,6 +227,7 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
         "allowShortCircuit": true,
         "allowTaggedTemplates": true,
         "allowTernary": true,
+        "enforceForJSX": false,
       },
     ],
     "@typescript-eslint/no-unused-vars": [
@@ -342,6 +343,8 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
       2,
       {
         "allowImplicit": true,
+        "allowVoid": false,
+        "checkForEach": false,
       },
     ],
     "arrow-body-style": [
@@ -362,6 +365,8 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
       0,
       {
         "ignoreDestructuring": false,
+        "ignoreGlobals": false,
+        "ignoreImports": false,
         "properties": "never",
       },
     ],
@@ -384,6 +389,7 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
     "class-methods-use-this": [
       2,
       {
+        "enforceForClassFields": true,
         "exceptMethods": [],
       },
     ],
@@ -538,6 +544,7 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
       2,
       {
         "allowUnsafeDynamicCyclicDependency": false,
+        "disableScc": false,
         "ignoreExternal": false,
         "maxDepth": "∞",
       },
@@ -671,6 +678,7 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
             "internal",
           ],
         ],
+        "named": false,
         "warnOnUnassignedImports": false,
       },
     ],
@@ -1240,6 +1248,7 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
         ],
         "newIsCap": true,
         "newIsCapExceptions": [],
+        "properties": true,
       },
     ],
     "no-alert": [
@@ -1394,6 +1403,7 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
       {
         "allow": [],
         "boolean": false,
+        "disallowTemplateShorthand": false,
         "number": true,
         "string": true,
       },
@@ -1923,6 +1933,11 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
         "allow": [],
         "allowAfterSuper": false,
         "allowAfterThis": false,
+        "allowAfterThisConstructor": false,
+        "allowFunctionParams": true,
+        "allowInArrayDestructuring": true,
+        "allowInObjectDestructuring": true,
+        "enforceInClassFields": false,
         "enforceInMethodNames": true,
       },
     ],
@@ -1965,6 +1980,7 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
         "allowShortCircuit": true,
         "allowTaggedTemplates": true,
         "allowTernary": true,
+        "enforceForJSX": false,
       },
     ],
     "no-unused-labels": [

diff --git a/tests/snapshot-test/eslintrc/storybook/__snapshots__/snapshot.test.js.snap b/tests/snapshot-test/eslintrc/storybook/__snapshots__/snapshot.test.js.snap
@@ -227,6 +227,7 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
         "allowShortCircuit": true,
         "allowTaggedTemplates": true,
         "allowTernary": true,
+        "enforceForJSX": false,
       },
     ],
     "@typescript-eslint/no-unused-vars": [
@@ -342,6 +343,8 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
       2,
       {
         "allowImplicit": true,
+        "allowVoid": false,
+        "checkForEach": false,
       },
     ],
     "arrow-body-style": [
@@ -362,6 +365,8 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
       0,
       {
         "ignoreDestructuring": false,
+        "ignoreGlobals": false,
+        "ignoreImports": false,
         "properties": "never",
       },
     ],
@@ -384,6 +389,7 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
     "class-methods-use-this": [
       2,
       {
+        "enforceForClassFields": true,
         "exceptMethods": [],
       },
     ],
@@ -538,6 +544,7 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
       2,
       {
         "allowUnsafeDynamicCyclicDependency": false,
+        "disableScc": false,
         "ignoreExternal": false,
         "maxDepth": "∞",
       },
@@ -671,6 +678,7 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
             "internal",
           ],
         ],
+        "named": false,
         "warnOnUnassignedImports": false,
       },
     ],
@@ -1009,6 +1017,7 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
         ],
         "newIsCap": true,
         "newIsCapExceptions": [],
+        "properties": true,
       },
     ],
     "no-alert": [
@@ -1163,6 +1172,7 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
       {
         "allow": [],
         "boolean": false,
+        "disallowTemplateShorthand": false,
         "number": true,
         "string": true,
       },
@@ -1692,6 +1702,11 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
         "allow": [],
         "allowAfterSuper": false,
         "allowAfterThis": false,
+        "allowAfterThisConstructor": false,
+        "allowFunctionParams": true,
+        "allowInArrayDestructuring": true,
+        "allowInObjectDestructuring": true,
+        "enforceInClassFields": false,
         "enforceInMethodNames": true,
       },
     ],
@@ -1734,6 +1749,7 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
         "allowShortCircuit": true,
         "allowTaggedTemplates": true,
         "allowTernary": true,
+        "enforceForJSX": false,
       },
     ],
     "no-unused-labels": [