Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add Atlas Controller (atlasclient) #1

Merged
merged 9 commits into from
Feb 22, 2020
Merged

Feature: add Atlas Controller (atlasclient) #1

merged 9 commits into from
Feb 22, 2020

Conversation

prashantmital
Copy link
Contributor

No description provided.

@prashantmital prashantmital mentioned this pull request Feb 20, 2020
Closed
4 tasks
@prashantmital prashantmital force-pushed the feature/Atlas-Controller branch from c0a3c0b to 5a45ccf Compare February 20, 2020 01:10
ShaneHarvey
ShaneHarvey reviewed Feb 20, 2020
View reviewed changes
Copy link

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is Python 3 only, did you consider using type annotations?

atlasclient/exceptions.py Outdated Show resolved Hide resolved
atlasclient/exceptions.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
atlasclient/client.py Show resolved Hide resolved
atlasclient/client.py Outdated Show resolved Hide resolved
@prashantmital
Copy link
Contributor Author

Responded to your review @ShaneHarvey.

Since this is Python 3 only, did you consider using type annotations?

I did consider using type annotations but due to my unfamiliarity with them, I felt rather slowed down by it. Due to the tiny size of this codebase, I think it can be added with relative ease in the near future.

ShaneHarvey
ShaneHarvey reviewed Feb 20, 2020
View reviewed changes
atlasclient/exceptions.py Outdated Show resolved Hide resolved
atlasclient/exceptions.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
astrolabe/version.py Outdated Show resolved Hide resolved
@prashantmital prashantmital merged commit fa7c5e1 into mongodb-labs:master Feb 22, 2020
@prashantmital prashantmital deleted the feature/Atlas-Controller branch February 22, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@mbroadst mbroadst Awaiting requested review from mbroadst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashantmital @ShaneHarvey