Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-5057): add compass:exports fields to package.json #561

Merged
merged 1 commit into from
Feb 9, 2023
Merged

chore(NODE-5057): add compass:exports fields to package.json #561

merged 1 commit into from
Feb 9, 2023

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Feb 9, 2023

This helps resolve Compass-specific bundling headaches.

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@addaleax
chore: add compass:exports fields to package.json
3c375af 
This helps resolve Compass-specific bundling headaches.
@nbbeeken nbbeeken changed the title chore: add compass:exports fields to package.json chore(NODE-5057): add compass:exports fields to package.json Feb 9, 2023
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 9, 2023
nbbeeken
nbbeeken approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

from slack: the issue with type definitions doesn't apply here, this is a custom top-level field, not related to the existing "exports" conditions

@nbbeeken nbbeeken merged commit 6ef1000 into main Feb 9, 2023
@nbbeeken nbbeeken deleted the compass-exports-field branch February 9, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addaleax @nbbeeken @dariakp