Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-6070): delete old benchmark scripts and remove unneeded devDependencies #667

Merged
merged 7 commits into from
Apr 8, 2024
Merged

chore(NODE-6070): delete old benchmark scripts and remove unneeded devDependencies #667

merged 7 commits into from
Apr 8, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Apr 5, 2024 •
edited
Loading

What is changing?

  • Removed etc/benchmark directory
  • removed v8-profiler-next dev dependency to fix test setup failures
  • removed chalk dev dependency
  • add tar dev dependency for testing. This was added as our tests were unexpectedly depending on the tar package that was brought in via the v8-profiler-next package
Is there new documentation needed for these changes?

What is the motivation for this change?

  • v8-profiler-next doesn't work with Node.js latest and is not needed

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as draft April 5, 2024 22:10
@W-A-James W-A-James marked this pull request as ready for review April 8, 2024 04:29
W-A-James
W-A-James commented Apr 8, 2024
View reviewed changes
test/node/string_test.js Outdated Show resolved Hide resolved
@W-A-James W-A-James changed the title chore(NODE-6070): delete old benchmark scripts and remove unneeded devDependency chore(NODE-6070): delete old benchmark scripts and remove unneeded devDependencies Apr 8, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB self-requested a review April 8, 2024 14:13
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 8, 2024
aditi-khare-mongoDB
aditi-khare-mongoDB approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into this and finding a solution so quickly!

@aditi-khare-mongoDB aditi-khare-mongoDB added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 8, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB merged commit c8b5a64 into 5.x Apr 8, 2024
3 checks passed
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the delete-old-benchmark-scripts branch April 8, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditi-khare-mongoDB aditi-khare-mongoDB aditi-khare-mongoDB approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W-A-James @baileympearson @aditi-khare-mongoDB