Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MONGOCRYPT-411 use ${branch_name}, not ${branch} #271

Merged
merged 1 commit into from
Mar 18, 2022
Merged

MONGOCRYPT-411 use ${branch_name}, not ${branch} #271

merged 1 commit into from
Mar 18, 2022

Conversation

kevinAlbs
Copy link
Contributor

@kevinAlbs kevinAlbs commented Mar 18, 2022 •
edited
Loading

This was my mistake in #264.

The default expansion name is ${branch_name}, not ${branch}.

This was discovered after doing the 1.3.2-rc0 release.

@kevinAlbs kevinAlbs requested a review from rcsanchez97 March 18, 2022 17:57
rcsanchez97
rcsanchez97 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Collaborator

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I definitely missed that as well. LGTM.

@kevinAlbs kevinAlbs merged commit 1995ee4 into master Mar 18, 2022
@kevinAlbs kevinAlbs deleted the branch_fix.m411 branch March 18, 2022 20:57
kevinAlbs added a commit that referenced this pull request Mar 18, 2022
@kevinAlbs
MONGOCRYPT-411 use ${branch_name}, not ${branch} (#271)
5ae8041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcsanchez97 rcsanchez97 rcsanchez97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinAlbs @rcsanchez97