-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSHARP-4124: Replaced docs.mongodb.com with www.mongodb.com/docs and similar URL redirect fixes. #782
Conversation
…similar URL redirect fixes.
|
||
<title>404 Page not found</title> | ||
|
||
<link rel="stylesheet" href="http://localhost:1313/mongo-java-driver/s/lib/bootstrap.min.css" type="text/css" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh)) mongo-java-driver also presents here https://github.com/mongodb/mongo-csharp-driver/tree/master/Docs/landing and here https://github.com/mongodb/mongo-csharp-driver/tree/master/Docs/reference/themes/mongodb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@@ -13,7 +13,7 @@ tests: | |||
filter: {x: 'PING'} | |||
update: | |||
$set: {x: 'pong'} | |||
collation: { locale: 'en_US', strength: 2} # https://docs.mongodb.com/manual/reference/collation/#collation-document | |||
collation: { locale: 'en_US', strength: 2} # https://www.mongodb.com/docs/manual/reference/collation/#collation-document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not change this without changes in appropriate specs, otherwise we will always see a diff in these files comparing it with master, same for changes in spec files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we need to wait resolving of this question: https://jira.mongodb.org/browse/DRIVERS-2249?focusedCommentId=4477869&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-4477869
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. I've reverted the URL changes in the specs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…similar URL redirect fixes. (mongodb#782) Reverted CSharp4079Tests.cs and VersionedAPIExamples.cs changes from original f7d3598 commit
Updated docs.mongodb.com to www.mongodb.com/docs. Also ensured that we are using https consistently, fixed broken links, and replaced mongodb.org redirects with the correct URLs. I'll be putting up a separate PR for updating the live gh-pages documentation.