CLOUDP-238932: Validate maxDate and minDate before running command #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
reviewed
Mar 21, 2024
gssbzn
reviewed
Mar 22, 2024
Comment on lines
82
to
84
| if p.MaxDate, err = opts.ParseDate(opts.MaxDate); err != nil { | ||
| return p, err | ||
| } |
There was a problem hiding this comment.
Suggested change
| if p.MaxDate, err = opts.ParseDate(opts.MaxDate); err != nil { | |
| return p, err | |
| } | |
| if opts.MaxDate != "" { | |
| if p.MaxDate, err = opts.ParseDate(opts.MaxDate); err != nil { | |
| return nil, err | |
| } | |
| } |
There was a problem hiding this comment.
oh I see ParseDate is now empty safe, then this may not be needed
gssbzn
reviewed
Mar 22, 2024
gssbzn
reviewed
Mar 22, 2024
| @@ -54,7 +54,7 @@ func TestEvents(t *testing.T) { | |||
| orgEntity, | |||
| "list", | |||
| "--omitCount", | |||
| "--minDate="+time.Now().Add(-time.Hour*time.Duration(24)).Format("2006-01-02"), | |||
| "--minDate="+time.Now().Add(-time.Hour*time.Duration(24)).Format("2006-01-02T15:04:05-0700"), | |||
gssbzn
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-238932
closes #2793
Checklist
make fmtand formatted my codeFurther comments