CLOUDP-304933 Add operationId to API commands and restructure docs generation tool #3715
+98
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
changed the title
cveticm
requested changes
Mar 7, 2025
Comment on lines
37
to
-111
|
|
||
| for _, cmd := range atlasBuilder.Commands() { | ||
| if plugin.IsPluginCmd(cmd) && !isFirstClassPlugin(cmd) { | ||
| atlasBuilder.RemoveCommand(cmd) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Still need to remove non-first-class plugins to avoid generating docs for plugins.
There was a problem hiding this comment.
added back, but the way I see it, we will never run into this edge case, given we won't install plugins on CI, right?
There was a problem hiding this comment.
Not in CI, yes. But this just makes life easier on us as devs if we do work where we need to generate some docs changes and also have some plugin installed. Thanks for the change!
|
Coverage Report 📈
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add operationId to API commands and restructure docs generation tool
Jira ticket: CLOUDP-304933
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments