refactor: check err.code exists before checking if its in a set

mongodb · Aug 22, 2019 · dbfe4f5 · dbfe4f5
1 parent 4ec04f0
commit dbfe4f5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/core/error.js b/lib/core/error.js
@@ -192,7 +192,7 @@ function isNotMasterError(err) {
 }
 
 function isNodeShuttingDownError(err) {
-  return SDAM_NODE_SHUTTING_DOWN_ERROR_CODES.has(err.code);
+  return err.code && SDAM_NODE_SHUTTING_DOWN_ERROR_CODES.has(err.code);
 }
 
 /**

diff --git a/test/functional/connections_stepdown_tests.js b/test/functional/connections_stepdown_tests.js
@@ -4,7 +4,9 @@ const chai = require('chai');
 const expect = chai.expect;
 
 function ignoreNsNotFound(err) {
-  if (!err.message.match(/ns not found/)) throw err;
+  if (!err.message.match(/ns not found/)) {
+    throw err;
+  }
 }
 
 function connectionCount(db) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -192,7 +192,7 @@ function isNotMasterError(err) { @@
     }
     function isNodeShuttingDownError(err) {
-      return SDAM_NODE_SHUTTING_DOWN_ERROR_CODES.has(err.code);
+      return err.code && SDAM_NODE_SHUTTING_DOWN_ERROR_CODES.has(err.code);
     }
     /**
@@ Expand Down @@