Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(url parser): preserve auth creds when composing conn string #1641

Merged
merged 6 commits into from
Jan 19, 2018

Conversation

jlord
Copy link
Contributor

@jlord jlord commented Jan 17, 2018

Preserve the auth credentials used with a dns/txt record uri when composing a new connection string for the url parser.

This fix is also applied to the current version in #1640.

NODE-1286

test/runner.js Outdated
@@ -273,6 +273,7 @@ var testFiles = [
, '/test/functional/byo_promises_tests.js'

// Functionality tests
, '/test/functional/dns_txt_records_tests.js'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename this like mongodb_srv_tests.js?

@jlord jlord merged commit ecedce6 into 2.2 Jan 19, 2018
@jlord jlord deleted the backport-auth-dns-fix branch January 19, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants