-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: only store topology on MongoClient #2594
Merged
HanaPearlman
merged 16 commits into
mongodb:master
from
HanaPearlman:NODE-2850/master/topology-on-client
Nov 6, 2020
+183
−211
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6c4982b
only store topology on client, first pass
HanaPearlman e0cf415
pull error up before execute op
HanaPearlman 42f7883
add client closed error
HanaPearlman 51929a5
use new custom error
HanaPearlman cc16e89
pull up error from executeLegacyOperation
HanaPearlman 631db82
small fixes
HanaPearlman 147e78b
push down error check to decorate with collation
HanaPearlman 7a50664
push error check to execute operation
HanaPearlman 803e11c
Merge branch 'master' into NODE-2850/master/topology-on-client
HanaPearlman 048c4b7
do not add topology getter to collection
HanaPearlman 642d882
add some method names during client closed errors
HanaPearlman 416d3ce
be consistent with db topology access
HanaPearlman d2a1e75
two options inheritance fixes in Db
HanaPearlman 588cbec
create getTopology util
HanaPearlman 884c551
move getTopology to topology file
HanaPearlman e218676
implement changes
HanaPearlman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be able to use
getTopology
to remove the need to attach atopology
property onChangeStream
as well