test: Complete all matching operations #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the unfied spec test schema this scaffolding outlines the structure of a unified runner. Most tests are skipped by the runOn requirements or not implemented errors thrown by empty operation functions. NODE-2287
Adds special operations support i.e. $$unsetOrMatches for testing nested schema equality of results and events. Adds Recursive equality test that tracks the path into the object it is testing for ease of error tracing. Enable Change Stream tests with the repurposed EventsCollector class to iterate change events. Adds find, insertMany, iterateUntilDocumentOrError, and failPoint operations. NODE-2287
nbbeeken
force-pushed
the
NODE-2287/UnifiedTestFormat-2
branch
from
5edf26a to
a874e5c
Compare
Adds a check that asserts when at a recursion depth greater than 1 that documents do not have extra keys
durran
reviewed
Jan 25, 2021
| } | ||
|
|
||
| const TYPE_MAP = new Map(); | ||
| function typeof_double(actual): actual is number | Double { |
There was a problem hiding this comment.
Just out of curiosity is there a pattern of using snake case in typescript? I hadn't seen this before.
There was a problem hiding this comment.
Could we perhaps have the functions inline in the Map.set calls? E.g.
TYPE_MAP.set('double', function (actual): actual is number | Double {
return typeof actual === 'number' || actual._bsontype === 'Double';
});
There was a problem hiding this comment.
Inlined them to arrow functions, I over prepared here for more complex logic than was actually needed 😅
emadum
approved these changes
Jan 27, 2021
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Adds special operations support i.e. $$unsetOrMatches for testing nested schema equality of results and events. Adds Recursive equality test that tracks the path into the object it is testing for ease of error tracing. Enable Change Stream tests with the repurposed EventsCollector class to iterate change events. Adds find, insertMany, iterateUntilDocumentOrError, and failPoint operations. NODE-2287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds special operations support i.e. $$unsetOrMatches for testing
nested schema equality of results and events. Adds Recursive
equality test that tracks the path into the object it is testing
for ease of error tracing. Enable Change Stream tests with the
repurposed EventsCollector class to iterate change events. Adds
find, insertMany, iterateUntilDocumentOrError, and failPoint operations.
NODE-2287