Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support bson property on Topology class #2721

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

nbbeeken
Copy link
Contributor

This addresses an incompatibility with the existing versions of
mongodb-client-encryption which falls back on the bson library
being attached to the topology class.

NODE-3041

@nbbeeken nbbeeken force-pushed the NODE-3041/support-legacy-bson-on-topology branch from 25fea33 to 5edc3ea Compare January 27, 2021 19:38
This addresses an incompatibility with the existing versions of
mongodb-client-encryption which falls back on the bson library
being attached to the topology class.

NODE-3041
@nbbeeken nbbeeken force-pushed the NODE-3041/support-legacy-bson-on-topology branch from 5edc3ea to 2fce98d Compare January 27, 2021 19:58
@nbbeeken nbbeeken marked this pull request as ready for review January 28, 2021 15:05
@nbbeeken nbbeeken requested review from emadum and durran January 28, 2021 15:05
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit 00b1374 into 4.0 Jan 29, 2021
@nbbeeken nbbeeken deleted the NODE-3041/support-legacy-bson-on-topology branch January 29, 2021 15:03
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
Addresses an incompatibility with the existing versions of
mongodb-client-encryption which falls back on the bson library
being attached to the topology class.

NODE-3041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants