test(NODE-4965): unskip FLE range index spec tests and implement spec prose tests #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Jan 20, 2023
test/integration/client-side-encryption/range_explicit_encryption.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/range_explicit_encryption.prose.test.ts
Outdated
Show resolved
Hide resolved
.evergreen/config.yml
Outdated
| @@ -2132,7 +2132,7 @@ tasks: | |||
| - func: bootstrap kms servers | |||
| - func: run custom csfle tests | |||
| vars: | |||
| CSFLE_GIT_REF: ff9e095eaf72f9e442761f69080dae159a395d94 | |||
There was a problem hiding this comment.
This is pointing at your branch correct? just leaving open so we can update this to the commit on main when its there
There was a problem hiding this comment.
correct. once my PR on libmongocrypt merges, we can update this to the latest
test/integration/client-side-encryption/range_explicit_encryption.prose.test.ts
Outdated
Show resolved
Hide resolved
dariakp
requested changes
Jan 23, 2023
test/integration/client-side-encryption/range_explicit_encryption.prose.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
requested changes
Jan 23, 2023
test/integration/client-side-encryption/range_explicit_encryption.prose.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
requested changes
Jan 23, 2023
test/integration/client-side-encryption/range_explicit_encryption.prose.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
requested changes
Jan 23, 2023
test/integration/client-side-encryption/range_explicit_encryption.prose.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
added
Team Review
nbbeeken
approved these changes
Jan 23, 2023
nbbeeken
requested changes
Jan 23, 2023
test/integration/client-side-encryption/client_side_encryption.range.prose.ts
Outdated
Show resolved
Hide resolved
nbbeeken
previously approved these changes
Jan 23, 2023
baileympearson
force-pushed
the
NODE-4965-implement-range-index-prose-tests
branch
from
ad17243 to
7595e7f
Compare
dariakp
previously approved these changes
Jan 24, 2023
nbbeeken
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR adds spec tests for Decimal128 range index queries, unskips the existing range index tests and adds all the prose tests related to range indexes.
CI will be mostly red until mongodb/libmongocrypt#533 merges. Serverless and mongosh failures are failing on main too.
We can confirm that the changes work as expected on the custom dependency tests from a pinned commit - logs here.
Is there new documentation needed for these changes?
Not in the driver, no.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript