DRIVERS-2882 Add Kubernetes Support for OIDC #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blink1073 Is this ready to review? Asking since it's still in draft... If so I'll have a look. |
|
Hey @durran, we're looking for a second implementer actually! We can't test AKS until server 8.0.1 is available in Atlas, but otherwise this is reviewable. I see that is has a conflict, I'll update. |
|
mongodb/mongo-python-driver#1759 is now passing for EKS and GKE. |
|
@blink1073 Ok thanks, I'll see if I can get this into Node on the weekend. |
durran
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Node impl: mongodb/node-mongodb-native#4270
Not for others only to create one pod per type (eks, gke) per task group.
5 tasks
blink1073
requested review from
comandeo-mongo,
dariakp and
JamesKovacs
and removed request for
a team,
comandeo-mongo and
dariakp
|
All green as well for AKS on NODE. LGTM. |
|
All variants are currently passing in Python as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
PYTHON-4330 Add Kubernetes Support for OIDC mongo-python-driver#1759
clusters, and serverless).