Use Mongoid::Config.models to get the list of all available models in mongoid_slug.rake #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR will fix #247.
My proposal is to use
Mongoid::Config.models
(https://www.rubydoc.info/github/mongoid/mongoid/Mongoid/Config#models-instance_method) to get the list of all available models instead of iterating through allModule
constants and check ifMongoid::Slug
is included in the model usingconst.ancestors.include?(Mongoid::Slug)
which is much safer to use.This fix will prevent the task from failing with errors like this: