Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off PWM when duty cycle is set to zero #6

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

Mangero
Copy link
Contributor

@Mangero Mangero commented Sep 30, 2019

It is generally expected that a PWM signal should remain low if it has a
duty cycle of zero. This commit introduces such behaviour by turning PWM
off when duty cycle is set to zero (or lower).

Fixes: #3

It is generally expected that a PWM signal should remain low if it has a
duty cycle of zero. This commit introduces such behaviour by turning PWM
off when duty cycle is set to zero (or lower).

Fixes: mongoose-os-libs#3
@rojer rojer merged commit 783b43d into mongoose-os-libs:master Oct 1, 2019
@rojer
Copy link
Contributor

rojer commented Oct 1, 2019

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on ESP8266 passing zero for duty to mgos_pwm_set doesn't make it actually zero
2 participants