-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in production #323
Comments
I think we are passing in null for frequency_number even though it
shouldn't be possible. The best fix would be to make frequency_number
nullable in the database, since it's only necessary if frequency_type isn't
one_time. Adding 1 as default should also fix it.
…On Fri, Jun 16, 2017 at 12:31 Régis Freyd ***@***.***> wrote:
@yamakadi <https://github.com/yamakadi> do you see what it can be?
Happened a lot since we merged the big PR.
Jun 15 23:28:33 monica laravel: production.ERROR: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'frequency_number' cannot be null in /home/forge/default/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:91 Stack trace:
#0 /home/forge/default/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php(91): PDOStatement->execute(NULL)
#1 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Connection.php(449): Doctrine\DBAL\Driver\PDOStatement->execute()
#2 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Connection.php(640): Illuminate\Database\Connection->Illuminate\Database\{closure}('insert into `re...', Array)
#3 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Connection.php(607): Illuminate\Database\Connection->runQueryCallback('insert into `re...', Array, Object(Closure))
#4 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Connection.php(450): Illuminate\Database\Connection->run('insert into `re...', Array, Object(Closure))
#5 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Connection.php(404): Illuminate\Database\Connection->statement('insert into `re...', Array)
#6 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Query/Processors/Processor.php(32): Illuminate\Database\Connection->insert('insert into `re...', Array)
#7 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php(2138): Illuminate\Database\Query\Processors\Processor->processInsertGetId(Object(Illuminate\Database\Query\Builder), 'insert into `re...', Array, 'id')
#8 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php(1247): Illuminate\Database\Query\Builder->insertGetId(Array, 'id')
#9 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php(684): Illuminate\Database\Eloquent\Builder->__call('insertGetId', Array)
#10 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php(649): Illuminate\Database\Eloquent\Model->insertAndSetId(Object(Illuminate\Database\Eloquent\Builder), Array)
#11 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php(518): Illuminate\Database\Eloquent\Model->performInsert(Object(Illuminate\Database\Eloquent\Builder))
#12 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php(284): Illuminate\Database\Eloquent\Model->save()
#13 /home/forge/default/vendor/laravel/framework/src/Illuminate/Support/helpers.php(936): Illuminate\Database\Eloquent\Relations\HasOneOrMany->Illuminate\Database\Eloquent\Relations\{closure}(Object(App\Reminder))
#14 /home/forge/default/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php(285): tap(Object(App\Reminder), Object(Closure))
#15 /home/forge/default/app/Http/Controllers/People/RemindersController.php(54): Illuminate\Database\Eloquent\Relations\HasOneOrMany->create(Array)
#16 [internal function]: App\Http\Controllers\People\RemindersController->store(Object(App\Http\Requests\People\RemindersRequest), Object(App\Contact))
#17 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(55): call_user_func_array(Array, Array)
#18 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(44): Illuminate\Routing\Controller->callAction('store', Array)
#19 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Route.php(203): Illuminate\Routing\ControllerDispatcher->dispatch(Object(Illuminate\Routing\Route), Object(App\Http\Controllers\People\RemindersController), 'store')
#20 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Route.php(160): Illuminate\Routing\Route->runController()
#21 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Router.php(574): Illuminate\Routing\Route->run() #22 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(30): Illuminate\Routing\Router->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #23 /home/forge/default/app/Http/Middleware/Authenticate.php(28): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #24 /home/forge/default/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): App\Http\Middleware\Authenticate->handle(Object(Illuminate\Http\Request), Object(Closure)) #25 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #26 /home/forge/default/app/Http/Middleware/CheckLocale.php(23): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #27 /home/forge/default/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): App\Http\Middleware\CheckLocale->handle(Object(Illuminate\Http\Request), Object(Closure)) #28 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #29 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php(41): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #30 /home/forge/default/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Routing\Middleware\SubstituteBindings->handle(Object(Illuminate\Http\Request), Object(Closure)) #31 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #32 /home/forge/default/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php(65): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #33 /home/forge/default/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Foundation\Http\Middleware\VerifyCsrfToken->handle(Object(Illuminate\Http\Request), Object(Closure)) #34 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #35 /home/forge/default/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #36 /home/forge/default/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\View\Middleware\ShareErrorsFromSession->handle(Object(Illuminate\Http\Request), Object(Closure)) #37 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #38 /home/forge/default/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(64): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #39 /home/forge/default/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Session\Middleware\StartSession->handle(Object(Illuminate\Http\Request), Object(Closure)) #40 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request)) #41 /home/forge/default/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php(37): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request)) #42 /home/forge/default/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(1 48): Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle(Object(Illuminate\Http\Request), Object(Closure)) #43 /home/forge/default/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#323>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYTaZWvw9-hELy2-mthYZpyjFA5RseN2ks5sEfcUgaJpZM4N7_BZ>
.
|
@yamakadi |
Logs say it comes from this https://github.com/monicahq/monica/blob/master/app/Http/Controllers/People/RemindersController.php#L54 but I don't see how we can have this situation. |
OK I've checked in production and while |
That's probably why I didn't notice, since the field is nullable in my
local database.
…On Fri, Jun 16, 2017 at 21:07 Régis Freyd ***@***.***> wrote:
Closed #323 <#323>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#323 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AYTaZRR13v5S0Bi8X6IfYfnWTVjXaBnEks5sEm_1gaJpZM4N7_BZ>
.
|
This issue has been automatically locked since there |
@yamakadi do you see what it can be? Happened a lot since we merged the big PR.
The text was updated successfully, but these errors were encountered: