refactor: remove assets from repository #4759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asbiin breaking how? |
|
@djaiss yes it's a breaking change as every deploy script will have to be updated to make it work. I suggest to create a v3.0.0 for that feature. |
I agree. |
|
🎉 This PR is included in version 2.22.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
asbiin
added a commit
that referenced
this pull request
Apr 30, 2021
asbiin
added a commit
that referenced
this pull request
Apr 30, 2021
BREAKING CHANGE: The assets are no longer embedded in source code: javascript, css, font files. Run `yarn install` then `yarn run production` to recreate them from sources, or download a [release file](https://github.com/monicahq/monica/releases) that contains compiled files. BREAKING CHANGE: For Heroku users: You'll have to manually go to `Settings` > `Buildpacks` and add buildpack: `nodejs`. See [this doc](https://github.com/monicahq/monica/blob/master/docs/installation/providers/heroku.md#update-from-2x-to-3x). BREAKING CHANGE: See more information about how to install a Monica instance [here](https://github.com/monicahq/monica/tree/master/docs/installation).
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve #136
It's a breaking change!
BREAKING CHANGE: The assets are no longer embedded in source code: javascript, css, font files. Run
yarn installthenyarn run productionto recreate them from sources, or download a release file that contains compiled files.BREAKING CHANGE: For Heroku users: You'll have to manually go to
Settings>Buildpacksand add buildpack:nodejs. See this doc.BREAKING CHANGE: See more information about how to install a Monica instance here.