Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yubikey support #1031

Merged
merged 43 commits into from
Jul 4, 2018
Merged

Yubikey support #1031

merged 43 commits into from
Jul 4, 2018

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Mar 21, 2018

Close #825

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Make sure that the change you propose is the smallest possible.
  • [] Screenshots are included if the PR changes the UI.
  • If you change the UI, make sure the user experience is consistent with the current interface.

Code-related tasks

  • [TODO] Tests added for this feature/bug.
  • Impact on the seeders.
  • Impact on the API.

If the code changes the SQL schema

  • Impact on account export.
  • Impact on importing data with vCard and .csv files.
  • Impact on account reset and deletion.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant, add the documentation about your feature in the README file.
  • Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

@monicahq monicahq deleted a comment from codecov bot Jun 12, 2018
@djaiss
Copy link
Member

djaiss commented Jun 19, 2018

@asbiin awesome!

@asbiin asbiin temporarily deployed to monica-team-pr-1031 June 21, 2018 16:43 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1031 June 22, 2018 21:50 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1031 June 25, 2018 22:07 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1031 July 2, 2018 20:23 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1031 July 2, 2018 20:41 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1031 July 2, 2018 20:41 Inactive
@asbiin
Copy link
Member Author

asbiin commented Jul 2, 2018

@evaryont

Firefox 60 and later: Nothing, it just works out of the box.

Except it does not, on my computer ...

@nogweii
Copy link

nogweii commented Jul 4, 2018

@asbiin Oh, after looking at the Javascript I believe that's because you are using the U2F JS API. Firefox implemented the WebAuthN specification instead of it, which is more general. I believe Chrome supports WebAuthN as well, though Google's login services still rely on the older U2F API.

@asbiin
Copy link
Member Author

asbiin commented Jul 4, 2018

@evaryont thanks ! I was not aware of this new API. I will try using it.

@asbiin asbiin temporarily deployed to monica-team-pr-1031 July 4, 2018 20:33 Inactive
@asbiin
Copy link
Member Author

asbiin commented Jul 4, 2018

@evaryont I will merge this right now, and we will implement WebAuthn later, see #1536. Thanks for the help!

@asbiin asbiin changed the title Yubikey support [wip] Yubikey support Jul 4, 2018
@asbiin asbiin merged commit 8a8debc into master Jul 4, 2018
@asbiin asbiin deleted the yubikey-support branch July 4, 2018 21:37
@github-actions
Copy link

github-actions bot commented Feb 6, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2FA Support U2F devices
3 participants