-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yubikey support #1031
Yubikey support #1031
Conversation
@asbiin awesome! |
@evaryont
Except it does not, on my computer ... |
@asbiin Oh, after looking at the Javascript I believe that's because you are using the U2F JS API. Firefox implemented the WebAuthN specification instead of it, which is more general. I believe Chrome supports WebAuthN as well, though Google's login services still rely on the older U2F API. |
@evaryont thanks ! I was not aware of this new API. I will try using it. |
@evaryont I will merge this right now, and we will implement WebAuthn later, see #1536. Thanks for the help! |
This pull request has been automatically locked since there |
Close #825
Checklist
Before submitting the PR
Code-related tasks
If the code changes the SQL schema
vCard
and.csv
files.Other tasks
UNRELEASED
.[wip]
in the title of the PR it is is not final yet. Remove[wip]
when ready. Otherwise the PR will be considered complete and rejected if it's not working.