Add #1056 Add a view of contacts who do not have tags associated with them [In review] #1112

turtles2 · 2018-04-07T01:48:01Z

Closes #1056 by adding a untagged tag. Also it adds a method for selecting contacts with an array of tags.

Pull from Main

Add webmanifest (monicahq#726)

Change to git clone URL as the git@ will not work without a granted private key.

…icahq#731) When the current day of the month is greater than the number of days in the month, the date class was rolling forward to March.

…ahq#735) This will allow a user to search there contacts by there contact information. It is done by entering the field they are searching by followed by a : then the search term. For example to find a contact with the email [email protected] you would enter email:[email protected]. Fixes monicahq#729

Merge Upstream

Revert "Fix URL::forceSchema to forceScheme (monicahq#730)" (monicahq#744)

Merge Remote

Merge

Merge Remote

Merge

* Add translation for preferences updated successfully message (monicahq#797) * Add ability to export a contact as CSV (monicahq#840) * Fix contact field types not being linked to account during vcard import (monicahq#841) Fix monicahq#838 * Add more unit test coverage for money helper (monicahq#842) * Add more unit tests for Gift model (monicahq#843) * Add Code Coverage to Browser tests (monicahq#813) * Using Live-code-coverage to get Code Coverage from http server * Add a new test to pass Login form * Add FakeUserTableSeeder to seed in testing env * Using SESSION_DRIVER=file in travis env * Add saucelabs connection (disable right now) * Update composer * Move codecov line (monicahq#844) * Add more unit tests for User, Tag, Reminder and PetCategory models (monicahq#845) * Add final unit tests for DateHelper (monicahq#846) * Add more unit tests for Task, User and Tag models (monicahq#848) * 2FA tests cover (monicahq#849) * More unit tests for many models (monicahq#851) * Add margin bottom to add contact form (monicahq#850) * Do not put specific editor files in gitignore (monicahq#855) * Bump version to 1.6.2 (monicahq#856) * Some more 2fa test (monicahq#854) * Fix avatar being invalid in the Contact API call (monicahq#863) * Add Annual plan (monicahq#861) * Fix annual plans generating an error for users exempt of the paid plan (monicahq#864) * Fix a regression when filtering the list of contacts based on tags (monicahq#801) * Update laravel-mix to version 2.0.0 (monicahq#847) * Add requirements section in README (monicahq#858) * Revert Laravel mix to 1.7.2 (monicahq#866) * Remove env variable from prod (monicahq#867) * Fix jquery-tags-input name import (monicahq#859) * Set DB_PREFIX to a real empty string (monicahq#873) * Fix Gitter link and readd badge for sonar (monicahq#871) * Add gifts_update_success (monicahq#876) * Update changelog with recent changes (monicahq#877) * Test php 7.2 and postgresql (monicahq#785) Running: - php 7.1 + mysql + selenium (browser) tests - php 7.2 + mysql - php 7.1 + postgresql * Add support for custom genders (monicahq#879) * Refactor destroyAndReplace method to facilitate unit testing (monicahq#880) * Add missing features in README (monicahq#881) * Activate saucelabs connection (monicahq#882) * Activate saucelabs (missing file) (monicahq#883) See monicahq#882 * Build assets on travis and deploy them on bintray (monicahq#884) * Fix deploy.json creation (monicahq#888) * Fix docker image (monicahq#885) * Remove nodejs and 'npm install' from image * Remove everything that is not usefull * Run composer with no-dev * Don't build docker image immediatly (monicahq#889) * Don't build docker image immediatly * Fix php serve making too much output * Print test results in script part * Better edit contact screen (monicahq#890) * Remove import contact function from Personalization screen (monicahq#891) * Launch browser tests with Dusk (monicahq#892) * And remove old (steward) tests * Add ability to search contacts through the API (monicahq#895) * Add default avatar color in the API (monicahq#896) * Fix default genders seed with setup:production (monicahq#898) * Fix heroku deploy (monicahq#901) default login created after installation : '[email protected]' / 'admin' * Tiny typo fix (monicahq#900) * Update installation docs (monicahq#903) * Bump version to 1.7.0 (monicahq#908) * Fix setup:production command (monicahq#909) * Bump version to 1.7.1 (monicahq#910) * Run tests with php 7.0 (monicahq#904) * Update vagrant script and doc (monicahq#907) * Remove trailing slash from post/get requests (monicahq#912) * Cleanup continuous integration environment (monicahq#913) Move scripts in a subdirectory * Fix contact deletion not working (monicahq#915) * Improve travis build (monicahq#916) * Bump version 1.7.2 (monicahq#919) * Docker run real cron (monicahq#906) * Use crontab for schedules * Update apache conf file * Clean composer cache after installation * Clean apk cache after installation * Fix travis file for deploy stages (monicahq#926) * Fix bintray tag set (monicahq#927) * Fix Patreon link in README (monicahq#923) * Remove trailing slash from routes (monicahq#918) * Add ability to associate and remove one or more tags to a contact via the API (monicahq#924) 3 new API methods have been added: * It allows to associate one or more tags with a contact, * It allows to remove one or more tags from a contact, * It allows to remove all the tags from a contact at once. * Improve contact search through the API (monicahq#930) * Add sort capabilities in the API (monicahq#933) * Add concept of notifications for reminders (monicahq#894) * Add crowdin configuration file (monicahq#936) * Rename some i18n folders (monicahq#938) * Update french translations (monicahq#939) * Fix broken search (monicahq#941) * Fixes based on sonar recommandations (monicahq#934) * Bump version 1.8.0 (monicahq#942) * Fix bintray deploy (monicahq#943) * Support unix socket to connect with mysql (monicahq#928) * Remove saucelabs (monicahq#945) * Test if .git directory is present (monicahq#950) * Fix notifications not being sent (monicahq#951) * Fix reset account deleting default account values (monicahq#956) This fixes monicahq#922 * Remove partial contacts from search results returned by the API (monicahq#957) * Fix gravatar support (monicahq#944) * Fix messages and localization on contact edit (monicahq#955) * Bump version to 1.8.1 (monicahq#962) * Fix docker image creating wrong storage directories (monicahq#963) * Update translations for it, pt, cz, ru, fr, de, cs (monicahq#940) * Add bullet points to call lists when rendered from markdown (monicahq#961) * Create a vagrant box (monicahq#967) * Build vagrant box on travis (monicahq#968) * Switching doc to the wiki (monicahq#969) * Update SQL Import instructions link (monicahq#972) * Fix issues found by static analysis (monicahq#878) * sonar-launch file has moved (monicahq#974) * Optimizations for composer (monicahq#952) * Add apcu optimization * Update composer * Require debugbar on dev only (monicahq#983) * Improve heroku integration (monicahq#970) * Use google2fa-laravel dev-master (monicahq#949) * Improve tests support (monicahq#984) * Use WithFaker trait * Add a scrollTo macro * Use specific chromedriver * Fix issues proposed by sonar (monicahq#986) * Remove env calls (monicahq#991) * Add codecov file (monicahq#993) * Fix Faker trait use (monicahq#995) * Update dependencies (monicahq#985) * Update CONTRIBUTING.md (monicahq#998) * Fix sonar issues (monicahq#999) * Open register page after a clean installation (monicahq#954) * Redirect to /register if there is no account * Remove default creation for [email protected] * Fix typo on readme.md (monicahq#1000) * Update axios to version 0.18.0 (monicahq#914) * Update axios to version 0.18.0 (monicahq#1006) See monicahq#914 * Update vue-i18n to version 7.6.0 (monicahq#1007) * Update laravel-mix to version 2.1.7 (monicahq#1009) * Reduce sonar complexity (monicahq#992) * Fix sonar bug (monicahq#1011) * Reduce precision in codecov setting (monicahq#1012) * Fix bug with return values (monicahq#1013) * Remove MoneyHelper from aliases (monicahq#1014) * Fix notification messages (monicahq#1016) * Add ability to sort tasks by completed_at attribute (monicahq#1021) * Add sorting capabilities to most models in the API (monicahq#1022) * Update Czech, Italian, Portuguese, Russian, German, French, Chinese Simplified, Hebrew language files (monicahq#966) * Add two new languages: Hebrew and Chinese Simplified (monicahq#1023) * Bump version to 1.8.2 (monicahq#1024) * Replace logo in README (monicahq#1027) * Fix vagrant install using bash (monicahq#1029) * Update i18n assets on build (monicahq#1032) * Bump enm1989/chromedriver from 2.36 to 2.37 (monicahq#1037) Bumps [enm1989/chromedriver](https://github.com/ENM1989/chromedriver) from 2.36 to 2.37. - [Release notes](https://github.com/ENM1989/chromedriver/releases) - [Commits](ENM1989/chromedriver@2.36...2.37) Signed-off-by: dependabot[bot] <[email protected]> * Bump barryvdh/laravel-debugbar from 3.1.3 to 3.1.4 (monicahq#1034) Bumps [barryvdh/laravel-debugbar](https://github.com/barryvdh/laravel-debugbar) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/barryvdh/laravel-debugbar/releases) - [Changelog](https://github.com/barryvdh/laravel-debugbar/blob/master/changelog.md) - [Commits](barryvdh/laravel-debugbar@v3.1.3...v3.1.4) Signed-off-by: dependabot[bot] <[email protected]> * Bump pragmarx/google2fa from 3.0.0 to 3.0.1 (monicahq#1039) Bumps [pragmarx/google2fa](https://github.com/antonioribeiro/google2fa) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/antonioribeiro/google2fa/releases) - [Changelog](https://github.com/antonioribeiro/google2fa/blob/master/changelog.md) - [Commits](antonioribeiro/google2fa@v3.0.0...v3.0.1) Signed-off-by: dependabot[bot] <[email protected]> * Add linkedin url in the Contact object returned by the API (monicahq#1042) * Fix called_at field in the Call object returned by the API (monicahq#1043) * Add with parameter in Contact object to retrieve contact fields (monicahq#1044) * Add yearly statistics to activities and calls object (monicahq#1049) * Bump jeroendesloovere/vcard from 1.5.2 to 1.6 (monicahq#1038) Bumps [jeroendesloovere/vcard](https://github.com/jeroendesloovere/vcard) from 1.5.2 to 1.6. - [Release notes](https://github.com/jeroendesloovere/vcard/releases) - [Changelog](https://github.com/jeroendesloovere/vcard/blob/master/CHANGELOG.md) - [Commits](jeroendesloovere/vcard@1.5.2...1.6) Signed-off-by: dependabot[bot] <[email protected]> * Bump symfony/dom-crawler from 3.0.9 to 4.0.6 (monicahq#1033) * Bump symfony/dom-crawler from 3.0.9 to 4.0.6 * Bump symfony/css-selector from 3.0.9 to 4.0.6 * Symplify return (monicahq#1054) * Use assertCount (monicahq#1052) * I18n improvements (monicahq#1060) * Add a default locale * Use html lang and dir attributes * Fix translations * Add pluralize forms * Fix i18n improvements (monicahq#1061) * Fix some codes and pluralize * Remove urls from locales * New Crowdin translations (monicahq#1025) * Add reference to Crowdin in the documentation (monicahq#1066) * Bump guzzlehttp/guzzle from 6.3.0 to 6.3.2 (monicahq#1063) Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 6.3.0 to 6.3.2. - [Release notes](https://github.com/guzzle/guzzle/releases) - [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md) - [Commits](guzzle/guzzle@6.3.0...6.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Use lang list instead of auto (monicahq#1068) * Use unsigned* columns (monicahq#1053) * Use now helper (monicahq#1051) * Fix i18n support (monicahq#1069) Fix i18n quotation Add hreflang on links Fix lang list on settings which does not appear ! Bug introduced with monicahq#1068 * New Crowdin translations (monicahq#1064) * Bump league/flysystem-aws-s3-v3 from 1.0.18 to 1.0.19 (monicahq#1067) Bumps [league/flysystem-aws-s3-v3](https://github.com/thephpleague/flysystem-aws-s3-v3) from 1.0.18 to 1.0.19. - [Release notes](https://github.com/thephpleague/flysystem-aws-s3-v3/releases) - [Changelog](https://github.com/thephpleague/flysystem-aws-s3-v3/blob/master/changelog.md) - [Commits](thephpleague/flysystem-aws-s3-v3@1.0.18...1.0.19) Signed-off-by: dependabot[bot] <[email protected]> * Fixed usage of wrong success message when adding existing contact as kid of someone (monicahq#1041) * Bump creativeorange/gravatar from 1.0.10 to 1.0.11 (monicahq#1074) * Bump creativeorange/gravatar from 1.0.10 to 1.0.11 Bumps [creativeorange/gravatar](https://github.com/creativeorange/gravatar) from 1.0.10 to 1.0.11. - [Release notes](https://github.com/creativeorange/gravatar/releases) - [Commits](creativeorange/gravatar@v1.0.10...v1.0.11) Signed-off-by: dependabot[bot] <[email protected]> * Order lastname and middlename parameters correctly for contact->setName call (monicahq#1073) * Update i18n messages (monicahq#1076) * Use phpdbg and other test improvements (monicahq#1082) * Bump google2fa-laravel to version 0.2.0 (monicahq#1084) * Fix a duplicate key message (monicahq#1085) * Split app.js and generate separate javascript language files (monicahq#1079)

djaiss · 2018-05-08T01:23:35Z

The easiest would be to actually do this

<li class="f7 mt3">
   <a href="">View untagged contacts</a>
</li>

which would do

Simple solution, not super elegant but it does the trick and we can move on to another new feature 😀

turtles2 · 2018-05-08T19:10:59Z

@djaiss We should be good to merge this in.

djaiss

Some comments again 😀 On a sidenote, you should really start a branch off your master branch that is up to date, so you don't start a branch with 110 commits from 5 months ago. This will pollute the Git history quite a lot otherwise. Don't forget to pull master!

djaiss · 2018-05-08T23:47:07Z

CHANGELOG

@@ -44,6 +44,7 @@ v2.0.0 - 2018-04-12
 * Remove old documentation from sources
 * Fix Bug when editing gift

+


Why this new line?

djaiss · 2018-05-08T23:47:51Z

resources/lang/en/people.php

@@ -24,6 +24,8 @@
    'people_list_account_usage' => 'Your account usage: :current/:limit contacts',
    'people_list_account_upgrade_title' => 'Upgrade your account to unlock it to its full potential.',
    'people_list_account_upgrade_cta' => 'Upgrade now',
+    'people_list_untagged' => 'View Untagged Contacts',


Avoid uppercasing all words. View untagged contacts is better.

djaiss · 2018-05-08T23:48:01Z

resources/lang/en/people.php

@@ -24,6 +24,8 @@
    'people_list_account_usage' => 'Your account usage: :current/:limit contacts',
    'people_list_account_upgrade_title' => 'Upgrade your account to unlock it to its full potential.',
    'people_list_account_upgrade_cta' => 'Upgrade now',
+    'people_list_untagged' => 'View Untagged Contacts',
+    'people_list_filter_untag' => 'Showing all Untagged Contacts ',


djaiss · 2018-05-09T00:19:04Z

resources/views/people/index.blade.php

+                  @if ($tagLess)
+                      <p class="clear-filter">
+                        {{ trans('people.people_list_filter_untag') }}
+                        &nbsp


Nope 😀
Never use   for alignment purposes.

You should write

<p class="clear-filter"> <span class="mr2">{{ trans('people.people_list_filter_untag') }}</span> <a class="{{ \App\Helpers\LocaleHelper::getDirection() }}" href="/people">{{ trans('people.people_list_clear_filter') }}</a> </p>

djaiss · 2018-05-09T00:19:13Z

resources/views/people/index.blade.php

+              @if ($tagLess)
+                  <p class="clear-filter">
+                    {{ trans('people.people_list_filter_untag') }}
+                    &nbsp


same as above

turtles2 · 2018-05-09T14:59:50Z

@djaiss The Changes have been made. As for the Commits that will be resolved in all PRs going forward.

djaiss · 2018-05-13T12:32:38Z

Thanks @turtles2 😀

…nicahq#1112)

github-actions · 2021-02-08T00:16:57Z

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

turtles2 and others added 30 commits December 25, 2017 19:27

add DB_PREFIX

e7ed9a7

Update database.php

30c44c5

Merge pull request #1 from monicahq/master

6f8aae1

Pull from Main

Clean Up Commit

19039e6

Merge pull request #2 from monicahq/master

c780dd7

Add webmanifest (monicahq#726)

Fixes monicahq#350

7081fbe

Merge branch 'master' into master

d04ee9a

Bump version to 1.5.0 (monicahq#737)

08077a4

Change link to repository in the documentation (monicahq#728)

32a2a04

Change to git clone URL as the git@ will not work without a granted private key.

Fix URL::forceSchema to forceScheme (monicahq#730)

8a803e7

Fix an issue where February shows up as March in the date picker (mon…

0d842ec

…icahq#731) When the current day of the month is greater than the number of days in the month, the date class was rolling forward to March.

Merge pull request #4 from monicahq/master

1c266d4

Merge Upstream

Merge pull request #5 from monicahq/master

74d3251

Revert "Fix URL::forceSchema to forceScheme (monicahq#730)" (monicahq#744)

Merge pull request #6 from monicahq/master

68cb57e

Merge Remote

Add Two Factor Authentication (2FA) (monicahq#724)

29b9e3d

Add ability to view the details of an activity (monicahq#749)

85e2f48

API: Fetch Countries in alphabetical order (monicahq#752)

2a7aa38

Add better check on vCard imports (monicahq#753)

5d46b02

Fix a bug on notes posting (monicahq#772)

1f418d1

Add ability to sort contact list by last activity date (monicahq#775)

fa3bf2e

Merge pull request #8 from monicahq/master

e573843

Merge

Merge pull request #9 from monicahq/master

7f8c29e

Merge Remote

Merge pull request #10 from monicahq/master

166e26a

Merge

Delete contribute.md

b0117cf

Fixes monicahq#1072

1de7bf2

Update CHANGELOG

c05735f

Merge branch 'master' into 1072

468e3b8

Merge branch 'master' into 1072

27d71a3

turtles2 added 3 commits May 5, 2018 23:20

Merge branch 'master' into 1056

8a05a45

Merge branch 'master' into 1056

1b90e5a

Merge branch 'master' into 1056

b599c9f

djaiss assigned turtles2 and unassigned djaiss May 8, 2018

turtles2 and others added 3 commits May 8, 2018 12:55

Merge branch 'master' into 1056

9fb8737

Change Button

9bc86bf

Merge branch '1056' of https://github.com/turtles2/monica into 1056

bee007e

Merge branch 'master' into 1056

9071449

djaiss requested changes May 9, 2018

View reviewed changes

turtles2 and others added 2 commits May 9, 2018 09:37

Merge branch 'master' into 1056

5c915ed

Changes

27a2e4f

turtles2 and others added 5 commits May 10, 2018 09:28

Merge branch 'master' into 1056

9707e2a

Merge branch 'master' into 1056

a4566a2

Merge branch 'master' into 1056

90ba041

Fix Style

540d794

Style

2d81a02

djaiss approved these changes May 13, 2018

View reviewed changes

djaiss assigned djaiss and unassigned turtles2 May 13, 2018

Merge branch 'master' into 1056

8c9eacd

djaiss merged commit 4458baa into monicahq:master May 13, 2018

turtles2 deleted the 1056 branch May 14, 2018 03:27

superstrong pushed a commit to superstrong/monica that referenced this pull request May 19, 2018

Add a view for contacts who do not have tags associated with them (mo…

53770be

…nicahq#1112)

github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add #1056 Add a view of contacts who do not have tags associated with them [In review] #1112

Add #1056 Add a view of contacts who do not have tags associated with them [In review] #1112

turtles2 commented Apr 7, 2018 •

edited

Loading

djaiss commented May 8, 2018

turtles2 commented May 8, 2018

djaiss left a comment

djaiss May 8, 2018

djaiss May 8, 2018

djaiss May 8, 2018

djaiss May 9, 2018

djaiss May 9, 2018

turtles2 commented May 9, 2018

djaiss commented May 13, 2018

github-actions bot commented Feb 8, 2021

		@@ -44,6 +44,7 @@ v2.0.0 - 2018-04-12
		* Remove old documentation from sources
		* Fix Bug when editing gift

Add #1056 Add a view of contacts who do not have tags associated with them [In review] #1112

Add #1056 Add a view of contacts who do not have tags associated with them [In review] #1112

Conversation

turtles2 commented Apr 7, 2018 • edited Loading

djaiss commented May 8, 2018

turtles2 commented May 8, 2018

djaiss left a comment

Choose a reason for hiding this comment

djaiss May 8, 2018

Choose a reason for hiding this comment

djaiss May 8, 2018

Choose a reason for hiding this comment

djaiss May 8, 2018

Choose a reason for hiding this comment

djaiss May 9, 2018

Choose a reason for hiding this comment

djaiss May 9, 2018

Choose a reason for hiding this comment

turtles2 commented May 9, 2018

djaiss commented May 13, 2018

github-actions bot commented Feb 8, 2021

turtles2 commented Apr 7, 2018 •

edited

Loading