Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dates formatting rules to a translatable file #1113

Merged
merged 8 commits into from
Apr 13, 2018
Merged

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Apr 7, 2018

Close #1018

@codecov
Copy link

codecov bot commented Apr 7, 2018

Codecov Report

Merging #1113 into master will decrease coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #1113     +/-   ##
==========================================
- Coverage      39.6%   39.5%   -0.1%     
  Complexity       11      11             
==========================================
  Files           200     200             
  Lines          5259    5236     -23     
==========================================
- Hits           2081    2064     -17     
+ Misses         3178    3172      -6
Impacted Files Coverage Δ Complexity Δ
app/Helpers/DateHelper.php 100% <100%> (+5.4%) 0 <0> (ø) ⬇️
app/Reminder.php 100% <0%> (+2.1%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05bd0a5...7922a0b. Read the comment docs.

@asbiin asbiin changed the title Move formatting rules to a translatable file Move dates formatting rules to a translatable file Apr 7, 2018
@asbiin asbiin merged commit d3c4518 into master Apr 13, 2018
@asbiin asbiin deleted the i18n-localize-dates branch April 13, 2018 10:05
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localize list of hours
1 participant