Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to define which features you want active on the Contact sheet #1121

Merged
merged 13 commits into from
Apr 9, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Apr 8, 2018

This PR adds the ability to display/hide each "section" on the contact sheet (reminders, activities,...) account-wide. This is defined in a new Personalization settings.

image

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Make sure that the change you propose is the smallest possible.
  • Screenshots are included if the PR changes the UI.
  • If you change the UI, make sure the user experience is consistent with the current interface.

Code-related tasks

  • Tests added for this feature/bug.
  • Impact on the seeders.
  • Impact on the API.

If the code changes the SQL schema

  • Impact on account export.
  • Impact on importing data with vCard and .csv files.
  • Impact on account reset and deletion.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant, add the documentation about your feature in the README file.
  • Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

@codecov
Copy link

codecov bot commented Apr 8, 2018

Codecov Report

Merging #1121 into master will increase coverage by 0.1%.
The diff coverage is 47.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #1121     +/-   ##
==========================================
+ Coverage      38.9%   38.9%   +0.1%     
  Complexity       11      11             
==========================================
  Files           198     200      +2     
  Lines          5206    5245     +39     
==========================================
+ Hits           2020    2039     +19     
- Misses         3186    3206     +20
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/SettingsController.php 11.7% <ø> (ø) 0 <0> (ø) ⬇️
app/Jobs/ExportAccountAsSQL.php 0% <ø> (ø) 0 <0> (ø) ⬇️
...pp/Http/Controllers/Settings/ModulesController.php 0% <0%> (ø) 0 <0> (?)
app/Account.php 88.8% <100%> (+0.8%) 0 <0> (ø) ⬇️
app/Http/Controllers/ContactsController.php 23.3% <100%> (+0.7%) 0 <0> (ø) ⬇️
app/Providers/RouteServiceProvider.php 58.6% <28.6%> (-1.4%) 0 <0> (ø)
app/Module.php 50% <50%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d00bb2b...da11435. Read the comment docs.

@djaiss djaiss changed the title Add ability to define which features you want active on the Contact sheet [wip] Add ability to define which features you want active on the Contact sheet Apr 8, 2018
@djaiss djaiss merged commit 874a7f0 into master Apr 9, 2018
@djaiss djaiss deleted the 2018-04-04-customize-view branch April 11, 2018 15:37
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant