FakeContentTableSeeder now adds meaningfull data in ContactFields

[kidk]

This was added for #1284 as I needed meaningful data to test with.

[asbiin]

You should consider getting the contact_field_type_id from ContactFieldType and get the right data form depending on the name in ContactFieldType ?

[kidk]

Thanks @asbiin I now retrieve a random row from ContactFieldType and generate according to that.

What do you think about adding a fake phone number and fake email by default, but still randomly generating the others? This would match the real usage of the tool more I think.

[asbiin]

@kidk "What do you think about adding a fake phone number and fake email by default, but still randomly generating the others? This would match the real usage of the tool more I think." Well it's interesting to have also cases of contacts without any ContactField as well. So your solution is elegant, I will merge it.

[kidk]

Ok for me. Thanks 👍

[github-actions]

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.