Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debts on the dashboard #1373

Merged
merged 9 commits into from
May 29, 2018
Merged

Add debts on the dashboard #1373

merged 9 commits into from
May 29, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented May 21, 2018 •
edited
Loading

This PR adds support for displaying debts on the dashboard, regardless of the contacts, in order to have a complete overview.

image

Code-related tasks

  • Tests added for this feature/bug.
  • Impact on the seeders.
  • Impact on the API.

If the code changes the SQL schema

  • Impact on account export.
  • Impact on importing data with vCard and .csv files.
  • Impact on account reset and deletion.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.

@djaiss djaiss requested a review from asbiin May 21, 2018 21:09
@djaiss djaiss mentioned this pull request May 22, 2018
Closed
asbiin
asbiin requested changes May 23, 2018
View reviewed changes
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it should be more usefull to see the total for 1 person instead of all details?

resources/assets/js/app.js
import moment from 'moment';
Vue.filter('formatDate', function(value) {
if (value) {
return moment(String(value)).format('LL')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, but it must support locale. Just add moment.locale(lang); on line 210 after loadLanguageAsync(window.Laravel.locale, true).then((lang) =>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I was lazy. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it and tested it, it seems to work. Can you double check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asbiin waiting for your validation here!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@asbiin
Copy link
Member

asbiin commented May 26, 2018

What about this ?
"Perhaps it should be more usefull to see the total for 1 person instead of all details?"

@djaiss
Copy link
Member Author

djaiss commented May 26, 2018

"Perhaps it should be more usefull to see the total for 1 person instead of all details?"

Yes, but it's also more work :-D But yeah, it would be interesting. But we can ship this as is, then improve it in another PR.

@djaiss djaiss merged commit f7757c9 into master May 29, 2018
@djaiss djaiss deleted the 2018-05-21-dashboard-add-debts branch May 31, 2018 01:05
@github-actions
Copy link

github-actions bot commented Feb 7, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asbiin asbiin asbiin approved these changes

Assignees

@asbiin asbiin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djaiss @asbiin