Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timestamps timezone #1554

Merged
merged 5 commits into from
Jul 10, 2018
Merged

Update timestamps timezone #1554

merged 5 commits into from
Jul 10, 2018

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Jul 8, 2018

Since #1527 timestamps are stored in UTC, but older timestamps has to be migrated.

@asbiin asbiin requested a review from djaiss July 8, 2018 12:08
@djaiss
Copy link
Member

djaiss commented Jul 10, 2018

@asbiin I understand what you are trying to do here. I was wondering whether we should do it.
Let me explain.

Let's say the app was in 'US/Eastern' before and the user entered a birthdate 01/01/1980.

The birthday should always remain 01/01/1980 regardless of the timezone. But if we do what you want to do here, depending on the timezone, we might end up having 02/01/1980 for instance, which we don't want.

This means... I'm not sure this is the right idea here. Perhaps we shouldn't convert each date we stored so far.

@djaiss
Copy link
Member

djaiss commented Jul 10, 2018

Dismiss my comment. You are only affecting created_at and updated_at entries. My bad.

Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. You can merge if you want.

@asbiin asbiin merged commit f5888ac into master Jul 10, 2018
@asbiin asbiin deleted the fix/timestamps-timezone branch July 10, 2018 20:05
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants