Improve Date and DateTime parsing #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbiin
commented
Jul 15, 2018
| @@ -130,7 +130,7 @@ private function validateUpdate(Request $request) | |||
| ->respondWithError($validator->errors()->all()); | |||
| } | |||
|
|
|||
| $date = Carbon::createFromFormat('Y-m-d', $request->get('next_expected_date'), auth()->user()->timezone); | |||
| $date = DateHelper::parseDate($request->get('next_expected_date')); | |||
There was a problem hiding this comment.
Here next_expected_date must be parsed in iso format.
asbiin
commented
Jul 15, 2018
|
|
||
| return [ | ||
| 'signed' => true, | ||
| 'signed_date' => $signedDate->format(config('api.timestamp_format')), | ||
| 'signed_date' => DateHelper::getTimestamp($signedDate), |
There was a problem hiding this comment.
signed_date must be render in timestamp format, with UTC timezone
|
@asbiin this broke the Settings index view. I'll fix it in my PR. |
Merged
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve how dates and datetimes are parsed and rendered.
Add some function in
DateHelper: