Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix default temperature scale #2225

Merged
merged 6 commits into from
Jan 4, 2019
Merged

fix: fix default temperature scale #2225

merged 6 commits into from
Jan 4, 2019

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Dec 29, 2018

This PR fix 2 issues:

@djaiss
Copy link
Member

djaiss commented Dec 30, 2018

Good job.
The only thing (but I think it's ok) : as your change affects all the users, you might change the preferences of existing users.

@asbiin
Copy link
Member Author

asbiin commented Dec 30, 2018

What you mean with "existing users"? Did you see the script here: /database/migrations/2018_12_29_091017_default_temperature_scale.php ?

@asbiin asbiin merged commit 6d38132 into master Jan 4, 2019
@asbiin asbiin deleted the fix/temperature-scale-default branch January 4, 2019 10:23
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ErrorException: Trying to get property 'cca2' of non-object
2 participants
@asbiin @djaiss