Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register all app services as singleton #2337

Merged
merged 5 commits into from
Jan 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ New features:

Enhancements:

* Register all app services as singleton
* Docker image: add sentry-cli and run sentry:release command if sentry is enabled
* Refactor reminders by removing Notifications table and creating two new tables: reminder outbox and reminder sent
* Display the name of the contact field instead of the URL (Facebook instead of https:/facebook.com/johndoe)
Expand Down
4 changes: 2 additions & 2 deletions app/Console/Commands/ImportCSV.php
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ private function csvToContact($data, $account_id, $gender_id)
'postal_code' => $postalCode,
];

(new CreateAddress)->execute($request);
app(CreateAddress::class)->execute($request);
}

if (! empty($data[42])) {
Expand All @@ -196,7 +196,7 @@ private function csvToContact($data, $account_id, $gender_id)

$specialDate = $contact->setSpecialDate('birthdate', $birthdate->format('Y'), $birthdate->format('m'), $birthdate->format('d'));

(new CreateReminder)->execute([
app(CreateReminder::class)->execute([
'account_id' => $contact->account_id,
'contact_id' => $contact->id,
'initial_date' => $specialDate->date->toDateString(),
Expand Down
2 changes: 1 addition & 1 deletion app/Helpers/WeatherHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public static function getWeatherForAddress($address)
private static function callWeatherAPI(Address $address)
{
try {
$weather = (new GetWeatherInformation)->execute([
$weather = app(GetWeatherInformation::class)->execute([
'place_id' => $address->place->id,
]);
} catch (\Exception $e) {
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/Account/ApiCompanyController.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function show(Request $request, $companyId)
public function store(Request $request)
{
try {
$company = (new CreateCompany)->execute(
$company = app(CreateCompany::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -89,7 +89,7 @@ public function store(Request $request)
public function update(Request $request, $companyId)
{
try {
$company = (new UpdateCompany)->execute(
$company = app(UpdateCompany::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -117,7 +117,7 @@ public function update(Request $request, $companyId)
public function destroy(Request $request, $companyId)
{
try {
(new DestroyCompany)->execute([
app(DestroyCompany::class)->execute([
'account_id' => auth()->user()->account->id,
'company_id' => $companyId,
]);
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/Account/ApiGenderController.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function show(Request $request, $genderId)
public function store(Request $request)
{
try {
$gender = (new CreateGender)->execute(
$gender = app(CreateGender::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -89,7 +89,7 @@ public function store(Request $request)
public function update(Request $request, $genderId)
{
try {
$gender = (new UpdateGender)->execute(
$gender = app(UpdateGender::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -117,7 +117,7 @@ public function update(Request $request, $genderId)
public function destroy(Request $request, $genderId)
{
try {
(new DestroyGender)->execute([
app(DestroyGender::class)->execute([
'account_id' => auth()->user()->account->id,
'gender_id' => $genderId,
]);
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/Account/ApiPlaceController.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function show(Request $request, $placeId)
public function store(Request $request)
{
try {
$place = (new CreatePlace)->execute(
$place = app(CreatePlace::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -89,7 +89,7 @@ public function store(Request $request)
public function update(Request $request, $placeId)
{
try {
$place = (new UpdatePlace)->execute(
$place = app(UpdatePlace::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -117,7 +117,7 @@ public function update(Request $request, $placeId)
public function destroy(Request $request, $placeId)
{
try {
(new DestroyPlace)->execute([
app(DestroyPlace::class)->execute([
'account_id' => auth()->user()->account->id,
'place_id' => $placeId,
]);
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/ApiContactController.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public function show(Request $request, $id)
public function store(Request $request)
{
try {
$contact = (new CreateContact)->execute(
$contact = app(CreateContact::class)->execute(
$request->all()
+
[
Expand All @@ -118,7 +118,7 @@ public function store(Request $request)
public function update(Request $request, $contactId)
{
try {
$contact = (new UpdateContact)->execute(
$contact = app(UpdateContact::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -148,7 +148,7 @@ public function destroy(Request $request, $contactId)
'contact_id' => $contactId,
'account_id' => auth()->user()->account->id,
];
(new DestroyContact)->execute($data);
app(DestroyContact::class)->execute($data);

return $this->respondObjectDeleted($contactId);
}
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/ApiContactTagController.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function setTags(Request $request, $contactId)
});

foreach ($tags as $tag) {
(new AssociateTag)->execute([
app(AssociateTag::class)->execute([
'account_id' => auth()->user()->account->id,
'contact_id' => $contact->id,
'name' => $tag,
Expand Down Expand Up @@ -60,7 +60,7 @@ public function unsetTags(Request $request, $contactId)
$contactTags = $contact->tags()->get();

foreach ($contactTags as $tag) {
(new DetachTag)->execute([
app(DetachTag::class)->execute([
'account_id' => auth()->user()->account->id,
'contact_id' => $contact->id,
'tag_id' => $tag->id,
Expand Down Expand Up @@ -89,7 +89,7 @@ public function unsetTag(Request $request, $contactId)
});

foreach ($tags as $tag) {
(new DetachTag)->execute([
app(DetachTag::class)->execute([
'account_id' => auth()->user()->account->id,
'contact_id' => $contact->id,
'tag_id' => $tag,
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/ApiReminderController.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function show(Request $request, $reminderId)
public function store(Request $request)
{
try {
$reminder = (new CreateReminder)->execute(
$reminder = app(CreateReminder::class)->execute(
$request->all()
+
[
Expand All @@ -86,7 +86,7 @@ public function store(Request $request)
public function update(Request $request, $reminderId)
{
try {
$reminder = (new UpdateReminder)->execute(
$reminder = app(UpdateReminder::class)->execute(
$request->all()
+
[
Expand All @@ -113,7 +113,7 @@ public function update(Request $request, $reminderId)
public function destroy(Request $request, $reminderId)
{
try {
(new DestroyReminder)->execute([
app(DestroyReminder::class)->execute([
'account_id' => auth()->user()->account->id,
'reminder_id' => $reminderId,
]);
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/ApiTagController.php
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function show(Request $request, $id)
public function store(Request $request)
{
try {
$tag = (new CreateTag)->execute(
$tag = app(CreateTag::class)->execute(
$request->all()
+
[
Expand All @@ -84,7 +84,7 @@ public function store(Request $request)
public function update(Request $request, $id)
{
try {
$tag = (new UpdateTag)->execute(
$tag = app(UpdateTag::class)->execute(
$request->all()
+
[
Expand All @@ -109,7 +109,7 @@ public function update(Request $request, $id)
public function destroy(Request $request, $id)
{
try {
(new DestroyTag)->execute([
app(DestroyTag::class)->execute([
'tag_id' => $id,
'account_id' => auth()->user()->account->id,
]);
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/ApiTaskController.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function show(Request $request, $taskId)
public function store(Request $request)
{
try {
$task = (new CreateTask)->execute([
$task = app(CreateTask::class)->execute([
'account_id' => auth()->user()->account->id,
'contact_id' => ($request->get('contact_id') == '' ? null : $request->get('contact_id')),
'title' => $request->get('title'),
Expand All @@ -83,7 +83,7 @@ public function store(Request $request)
public function update(Request $request, $taskId)
{
try {
$task = (new UpdateTask)->execute(
$task = app(UpdateTask::class)->execute(
$request->all()
+
[
Expand All @@ -108,7 +108,7 @@ public function update(Request $request, $taskId)
public function destroy(Request $request, $taskId)
{
try {
(new DestroyTask)->execute([
app(DestroyTask::class)->execute([
'task_id' => $taskId,
'account_id' => auth()->user()->account->id,
]);
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/Contact/ApiAddressController.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function show(Request $request, $id)
public function store(Request $request)
{
try {
$address = (new CreateAddress)->execute(
$address = app(CreateAddress::class)->execute(
$request->all()
+
[
Expand All @@ -88,7 +88,7 @@ public function store(Request $request)
public function update(Request $request, $addressId)
{
try {
$address = (new UpdateAddress)->execute(
$address = app(UpdateAddress::class)->execute(
$request->all()
+
[
Expand All @@ -115,7 +115,7 @@ public function update(Request $request, $addressId)
public function destroy(Request $request, $addressId)
{
try {
(new DestroyAddress)->execute([
app(DestroyAddress::class)->execute([
'account_id' => auth()->user()->account->id,
'address_id' => $addressId,
]);
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/Contact/ApiCallController.php
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function show(Request $request, $callId)
public function store(Request $request)
{
try {
$call = (new CreateCall)->execute(
$call = app(CreateCall::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -90,7 +90,7 @@ public function store(Request $request)
public function update(Request $request, $callId)
{
try {
$call = (new UpdateCall)->execute(
$call = app(UpdateCall::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -118,7 +118,7 @@ public function update(Request $request, $callId)
public function destroy(Request $request, $callId)
{
try {
(new DestroyCall)->execute([
app(DestroyCall::class)->execute([
'account_id' => auth()->user()->account->id,
'call_id' => $callId,
]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public function show(Request $request, $conversationId)
public function store(Request $request)
{
try {
$conversation = (new CreateConversation)->execute(
$conversation = app(CreateConversation::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -116,7 +116,7 @@ public function store(Request $request)
public function update(Request $request, $conversationId)
{
try {
$conversation = (new UpdateConversation)->execute(
$conversation = app(UpdateConversation::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -145,7 +145,7 @@ public function update(Request $request, $conversationId)
public function destroy(Request $request, $conversationId)
{
try {
(new DestroyConversation)->execute([
app(DestroyConversation::class)->execute([
'account_id' => auth()->user()->account->id,
'conversation_id' => $conversationId,
]);
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/Contact/ApiLifeEventController.php
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function show(Request $request, $lifeEventId)
public function store(Request $request)
{
try {
$lifeEvent = (new CreateLifeEvent)->execute(
$lifeEvent = app(CreateLifeEvent::class)->execute(
$request->all()
+
[
Expand All @@ -81,7 +81,7 @@ public function store(Request $request)
public function update(Request $request, $lifeEventId)
{
try {
$lifeEvent = (new UpdateLifeEvent)->execute(
$lifeEvent = app(UpdateLifeEvent::class)->execute(
$request->all()
+
[
Expand All @@ -108,7 +108,7 @@ public function update(Request $request, $lifeEventId)
public function destroy(Request $request, $lifeEventId)
{
try {
(new DestroyLifeEvent)->execute([
app(DestroyLifeEvent::class)->execute([
'account_id' => auth()->user()->account->id,
'life_event_id' => $lifeEventId,
]);
Expand Down
6 changes: 3 additions & 3 deletions app/Http/Controllers/Api/Contact/ApiMessageController.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function store(Request $request, int $conversationId)
}

try {
(new AddMessageToConversation)->execute(
app(AddMessageToConversation::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -69,7 +69,7 @@ public function update(Request $request, int $conversationId, int $messageId)
}

try {
(new UpdateMessage)->execute(
app(UpdateMessage::class)->execute(
$request->all()
+
[
Expand Down Expand Up @@ -108,7 +108,7 @@ public function destroy(Request $request, int $conversationId, int $messageId)
}

try {
(new DestroyMessage)->execute([
app(DestroyMessage::class)->execute([
'account_id' => auth()->user()->account->id,
'conversation_id' => $conversationId,
'message_id' => $messageId,
Expand Down
Loading