Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use singleton in all tests #2349

Merged
merged 3 commits into from
Jan 27, 2019
Merged

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Jan 27, 2019

Singletons were not used everywhere in our tests.

@djaiss djaiss changed the title chore: use singleton in all tests chore: use singleton in all tests [wip] Jan 27, 2019
@djaiss djaiss changed the title chore: use singleton in all tests [wip] chore: use singleton in all tests Jan 27, 2019
@djaiss djaiss merged commit 3981466 into master Jan 27, 2019
@djaiss djaiss deleted the 2019-01-27-use-singleton-everywhere branch March 2, 2019 12:10
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant