feat: shorten the value of the contact field #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaiss
reviewed
Jan 28, 2019
djaiss
reviewed
Jan 28, 2019
djaiss
reviewed
Jan 28, 2019
djaiss
reviewed
Jan 28, 2019
djaiss
reviewed
Jan 28, 2019
djaiss
reviewed
Jan 28, 2019
Co-Authored-By: asbiin <[email protected]>
Co-Authored-By: asbiin <[email protected]>
Co-Authored-By: asbiin <[email protected]>
Co-Authored-By: asbiin <[email protected]>
Co-Authored-By: asbiin <[email protected]>
Co-Authored-By: asbiin <[email protected]>
|
@djaiss thanks for the review |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes after #2288, which propose to use the name of the contact field instead of the value.
I propose to shorten the value if it's too long (26 characters seems good), and add a '...' after.