-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add journal entry edit option #2802
feat: add journal entry edit option #2802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very good !
Some little changes to do, but it's ok for me.
Updated :-) Let me know if you want anything else. Kind regards, |
@TeddyBear06 thanks a lot! As you can see I've updated some of your code, for the better. |
@asbiin Wonderful! Thanks a lot! I think this little feature will be great :-) |
i would suggest a little change in /Users/daniel/code/monicahq/monica/resources/assets/js/components/journal/partials/JournalContentEntry.vue:38
right now it does not work if monica is not installed in the root directory (i don't know how to do it myself) |
@danielsundermeier thanks for the feedback ! it's fixed. |
@danielsundermeier Good catch! @asbiin Thanks! |
This pull request has been automatically locked since there |
Hi,
Before spending time on writing tests, I would like to get your opinion about this feature.
It is my first attempt to contribute to this project, so I probably need to adapt :-)
Checklist
Before submitting the PR
[wip]
in the title of the PR it is is not final yet. Remove[wip]
when ready. Otherwise the PR will be considered complete and rejected if it's not working.General checks
Front-end changes
Backend/models changes
If the code changes the SQL schema
vCard
and.csv
files.Other tasks
UNRELEASED
.