Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Simplify Installation with Docker Steps #2817

Merged
merged 2 commits into from
Jul 10, 2019

Conversation

mohammed90
Copy link

The current Docker installation instructions cause an additional Monica container to start, sharing to the same MySQL container as the first one, to simply run the production setup. This can be avoided by replacing docker-compose run with docker-compose exec.

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • [n/a] If the PR is related to an issue or fix one, don't forget to indicate it.
  • Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Front-end changes

  • [n/a] If you change the UI, make sure to ask repositories administrators first about your changes by pinging @djaiss or @asbiin in this PR.
  • [n/a] Screenshots are included if the PR changes the UI.
  • [n/a] Front-end tests have been written with Cypress.

Backend/models changes

  • [n/a] The API has been updated.
  • [n/a] API's documentation has been added by submitting a pull request in the marketing website repository.
  • [n/a] Tests have been added for the new code.
  • [n/a] If you change a model, make sure the FakeContentTableSeeder is updated. We need seeders to develop locally and generate fake data.

If the code changes the SQL schema

  • [n/a] Make sure exporting account data as SQL is still working.
  • [n/a] Make sure your changes do not break importing data with vCard and .csv files.
  • [n/a] Make sure account reset and deletion still work.

Other tasks

  • [n/a] CHANGELOG entry added, if necessary, under UNRELEASED.
  • [n/a] CONTRIBUTORS entry added, if necessary.
  • [n/a] If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • [n/a] Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

The current Docker installation instructions cause an additional Monica container to start, sharing to the same MySQL container as the first one, to simply run the production setup. This can be avoided by replacing `docker-compose run` with `docker-compose exec`.
@CLAassistant
Copy link

CLAassistant commented Jul 5, 2019

CLA assistant check
All committers have signed the CLA.

@asbiin asbiin merged commit 10597ed into monicahq:master Jul 10, 2019
@asbiin
Copy link
Member

asbiin commented Jul 10, 2019

Thanks @mohammed90 !

@mohammed90 mohammed90 deleted the patch-1 branch July 10, 2019 13:37
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants