-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: oAuth proxy through HTTP kernel #2969
Conversation
This way your application can work with a single thread, also a more convenient way to do subrequests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thank you.
See my comment below, and don't forget to apply StyleCI patch please.
All done. Thank you for helping. |
@alirezamirsepassi Thank you for your help! |
This pull request has been automatically locked since there |
First of all thanks so much for taking the time to open a pull request and help the project. It's because of people like you that we love working on this project.
Please read the list below. Feel free to delete this text after but we need you to read it so we make sure that the project is consistent and remains of quality.
Checklist
Before submitting the PR
[wip]
in the title of the PR it is is not final yet. Remove[wip]
when ready. Otherwise the PR will be considered complete and rejected if it's not working.General checks
Front-end changes
Backend/models changes
If the code changes the SQL schema
vCard
and.csv
files.Other tasks
UNRELEASED
.