Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the Hebrew plural formula #3220

Merged
merged 5 commits into from
Nov 22, 2019
Merged

fix: add the Hebrew plural formula #3220

merged 5 commits into from
Nov 22, 2019

Conversation

yarons
Copy link

@yarons yarons commented Nov 18, 2019

Based on the CLDR rule, in the gettext form:
nplurals=4; plural=(n == 1) ? 0 : ((n == 2) ? 1 : ((n > 10 && n % 10 == 0) ? 2 : 3))

@asbiin Most of the mentioned sources show the former rule, not the current one.

Based on the CLDR rule, in the gettext form:
nplurals=4; plural=(n == 1) ? 0 : ((n == 2) ? 1 : ((n > 10 && n % 10 == 0) ? 2 : 3))

@asbiin Most of the mentioned sources show the former rule, not the current one.
@CLAassistant
Copy link

CLAassistant commented Nov 18, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok great!
See my review ..

resources/js/pluralization.js Outdated Show resolved Hide resolved
@yarons
Copy link
Author

yarons commented Nov 18, 2019

Yup, thanks, sorry for the trouble, feel free to merge 😅

@asbiin asbiin changed the title Adding the Hebrew plural formula fix: add the Hebrew plural formula Nov 21, 2019
@yarons
Copy link
Author

yarons commented Nov 22, 2019

Done.

@asbiin asbiin merged commit e1be47f into monicahq:master Nov 22, 2019
@asbiin
Copy link
Member

asbiin commented Nov 22, 2019

Thank you @yarons!
feal free to change translations now, but this change only affect vue.js client side translations, with curly brackets {}

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants