Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable api web navigation #3289

Merged
merged 16 commits into from
Dec 12, 2019
Merged

feat: enable api web navigation #3289

merged 16 commits into from
Dec 12, 2019

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Dec 7, 2019

This enables the api navigation into a browser, using actual credentials.
Authorization with token is still available.

This is really helpful, and is used on others apis like

I also added an url in some resources, to be able to navigate, for instance from /api/contacts to /api/contact/{id} easily.

The view of /api/:
image

@asbiin asbiin requested a review from djaiss December 7, 2019 09:58
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would that work in practice? Just point to the URL in your browser and get the JSON back?

app/Http/Resources/Contact/Contact.php Outdated Show resolved Hide resolved
routes/api.php Outdated Show resolved Hide resolved
@asbiin
Copy link
Member Author

asbiin commented Dec 12, 2019

@djaiss

Just point to the URL in your browser and get the JSON back?

Yes that's it. Just log in the standard web interface, then open the /api url in your browser!

@asbiin asbiin merged commit 958d4ed into master Dec 12, 2019
@asbiin asbiin deleted the feat/api-web-2019-12-07 branch December 12, 2019 21:22
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants