chore: add foreign keys on all tables

[djaiss]

This finishes the job of #2280 and will close #2280 too.

This adds foreign keys to all tables in Monica.

I also have written two new services:

• ResetAccount
• DestroyAccount

which makes the Settings controller a little bit lighter and cleaner. We don't need the old way of resetting and deleting accounts with the foreign keys everywhere.

[djaiss]

Ready for review @asbiin

[asbiin]

Great job! Really.
See my comments ...

[asbiin]

I'm a little concerned about the performance here. The migration took ~6 sec on the build pipeline, on an empty database.

[djaiss]

I'm a little concerned about the performance here. The migration took ~6 sec on the build pipeline, on an empty database.

It took 4 minutes on my machine with a database of the same size as the one in production.
The reason it takes so much time is because we have to look for every single entry in the DB in order to see if data really exists. This is why at the beginning of the file, I put the most frequent entries in an array instead of having to read from the DB again and again. This helped me reduced the time from 16 min to 4 min.

[djaiss]

Things that remain to be done

• Service to reset an account
• Service to delete an account
• Add foreign keys to contact table

[djaiss]

Ready for a new review @asbiin

[asbiin]

On account reset, could we consider delete the default data populated with $account->populateDefaultFields()?

Also, I think you could add a foreign key on avatar_photo_id?

[djaiss]

On account reset, could we consider delete the default data populated with $account->populateDefaultFields()?

Why? We don't need to touch the default populated fields during the reset account process.

Also, I think you could add a foreign key on avatar_photo_id?

Excellent point!

[djaiss]

@asbiin another review ;-)

[asbiin]

OK for me, go for it!

[github-actions]

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.