Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Missing fpm tag in docker-compose example #3340

Merged
merged 1 commit into from
Dec 22, 2019
Merged

docs: Missing fpm tag in docker-compose example #3340

merged 1 commit into from
Dec 22, 2019

Conversation

stuartmaxwell
Copy link

@stuartmaxwell stuartmaxwell commented Dec 21, 2019

The :fpm tag was missing from the docker-compose example.

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Front-end changes

  • If you change the UI, make sure to ask repositories administrators first about your changes by pinging @djaiss or @asbiin in this PR.
  • Screenshots are included if the PR changes the UI.
  • Front-end tests have been written with Cypress.

Backend/models changes

  • The API has been updated.
  • API's documentation has been added by submitting a pull request in the marketing website repository.
  • Tests have been added for the new code.
  • If you change a model, make sure the FakeContentTableSeeder is updated. We need seeders to develop locally and generate fake data.

If the code changes the SQL schema

  • Make sure exporting account data as SQL is still working.
  • Make sure your changes do not break importing data with vCard and .csv files.
  • Make sure account reset and deletion still work.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

The `:fpm` tag was missing from the docker-compose example.
@claassistantio
Copy link

claassistantio commented Dec 21, 2019

CLA assistant check
All committers have signed the CLA.

@stuartmaxwell stuartmaxwell changed the title Missing fpm tag in docker-compose example fix: Missing fpm tag in docker-compose example Dec 21, 2019
@asbiin asbiin changed the title fix: Missing fpm tag in docker-compose example docs: Missing fpm tag in docker-compose example Dec 22, 2019
@asbiin asbiin merged commit 8322f4e into monicahq:master Dec 22, 2019
@asbiin
Copy link
Member

asbiin commented Dec 22, 2019

Thanks @stuartmaxwell !

@stuartmaxwell stuartmaxwell deleted the patch-1 branch January 4, 2020 12:32
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants