Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(monkey-ci): update Monkey CI workflow for improvements (@MohakGupta2004) #6091

Closed
wants to merge 1 commit into from

Conversation

MohakGupta2004
Copy link

refactor: move reCAPTCHA site key to environment variable

  • Replaced hardcoded reCAPTCHA site key with a reference to GitHub Secrets.
  • Updated the workflow to use env.RECAPTCHA_SITE_KEY for enhanced security.
  • Prevents accidental exposure of sensitive information in the repository.

Description

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

refactor: move reCAPTCHA site key to environment variable

- Replaced hardcoded reCAPTCHA site key with a reference to GitHub Secrets.
- Updated the workflow to use `env.RECAPTCHA_SITE_KEY` for enhanced security.
- Prevents accidental exposure of sensitive information in the repository.
@MohakGupta2004 MohakGupta2004 changed the title Update monkey-ci.yml ci: update Monkey CI workflow for improvements Dec 4, 2024
@MohakGupta2004 MohakGupta2004 changed the title ci: update Monkey CI workflow for improvements ci(monkey-ci): update Monkey CI workflow for improvements (@MohakGupta2004) Dec 4, 2024
@Miodec
Copy link
Member

Miodec commented Dec 4, 2024

That key is a testing key provided by Google, its fine to expose. This PR is not necessary. Thank you though.

@Miodec Miodec closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants