-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace JSON.parse with parseJsonWithSchema (@dev-mohit06) #6207
Open
dev-mohit06
wants to merge
4
commits into
monkeytypegame:master
Choose a base branch
from
dev-mohit06:fix/json-parse-schema
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: Replace JSON.parse with parseJsonWithSchema (@dev-mohit06) #6207
dev-mohit06
wants to merge
4
commits into
monkeytypegame:master
from
dev-mohit06:fix/json-parse-schema
+85
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehmer
reviewed
Jan 23, 2025
fehmer
reviewed
Jan 23, 2025
fehmer
reviewed
Jan 23, 2025
fehmer
reviewed
Jan 23, 2025
fehmer
reviewed
Jan 23, 2025
fehmer
reviewed
Jan 23, 2025
fehmer
reviewed
Jan 23, 2025
fehmer
reviewed
Jan 23, 2025
fehmer
reviewed
Jan 23, 2025
fehmer
reviewed
Jan 23, 2025
fehmer
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dev-mohit06, nice work. I added some comments for you.
github-actions
bot
added
the
waiting for update
Pull requests or issues that require changes/comments before continuing
label
Jan 23, 2025
fehmer
reviewed
Jan 23, 2025
github-actions
bot
removed
the
waiting for update
Pull requests or issues that require changes/comments before continuing
label
Jan 23, 2025
…WithSchema (@dev-mohit06) - Updated schema definitions for better clarity and reusability. - Replaced with where applicable. - Addressed all review comments for better code consistency.
Hey @fehmer, could you take a look at the changes? |
fehmer
requested changes
Jan 24, 2025
github-actions
bot
added
waiting for update
Pull requests or issues that require changes/comments before continuing
and removed
waiting for update
Pull requests or issues that require changes/comments before continuing
labels
Jan 24, 2025
Hey @fehmer, could you take a look at the changes? |
github-actions
bot
added
the
waiting for review
Pull requests that require a review before continuing
label
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
frontend
User interface or web stuff
waiting for review
Pull requests that require a review before continuing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces raw JSON parsing with schema-based validation across frontend TypeScript files to improve type safety and error handling.
Scope of Changes
Updated JSON parsing in:
account.ts
import-export-settings.ts
analytics-controller.ts
local-storage-with-schema.ts
url-handler.ts
commandline/lists.ts
test/wikipedia.ts
Added schema in
test/custom-text.ts
:Benefits
Checks