Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suggestions and errors pointed out by shellcheck #12

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

DDSDerek
Copy link

@DDSDerek DDSDerek commented Jun 1, 2024

Fix

  • Suggestions and errors pointed out by shellcheck.

Feat

  • Reduce the number of duplicate layers.

@DDSDerek
Copy link
Author

DDSDerek commented Jun 1, 2024

@monlor Done

@monlor
Copy link
Owner

monlor commented Jun 1, 2024

@monlor Done

看下评论,有两点建议

@DDSDerek
Copy link
Author

DDSDerek commented Jun 1, 2024

@monlor Done

看下评论,有两点建议

这边没看到评论诶

emby/Dockerfile Outdated
RUN tar -zxvf shell2http_${SHELL2HTTP_VERSION}_linux_${TARGETARCH}.tar.gz -C /usr/bin/ shell2http && \
rm -rf shell2http_${SHELL2HTTP_VERSION}_linux_${TARGETARCH}.tar.gz && \
chmod +x /dumb-init
RUN curl -sL "https://github.com/msoap/shell2http/releases/download/v${SHELL2HTTP_VERSION}/shell2http_${SHELL2HTTP_VERSION}_linux_${TARGETARCH}.tar.gz" | \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emby里面没有curl wget命令也有问题,下载失败

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里恢复成原本使用ADD下载了

jellyfin/entrypoint.sh Show resolved Hide resolved
@monlor
Copy link
Owner

monlor commented Jun 1, 2024

@monlor Done

看下评论,有两点建议

这边没看到评论诶

不好意思😅 还得提交一下,现在应该有了🤣

@DDSDerek DDSDerek requested a review from monlor June 1, 2024 12:55
Copy link
Owner

@monlor monlor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡感谢PR

@monlor monlor merged commit 8febe2c into monlor:main Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants